Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88752
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>
References: <CAF+90c_io7TG4P+=cZrMEwhv=+9PxLQDQa9fijSG7OPfoKg6hA@mail.gmail.com>
	<CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>
Date: Mon, 12 Oct 2015 20:56:55 +0200
Message-ID: <CAF+90c9ENiRX=U1PY1Bn48b6coqfQ6RJVYsBg_xBRjba5uRvGg@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP internals <internals@lists.php.net>, Andrea Faulds <ajf@ajf.me>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Bob Weinand <bwoebi@php.net>, 
	Anatol Belski <anatol.php@belski.net>
Content-Type: multipart/alternative; boundary=089e013d171caba7a60521ece476
Subject: Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
From: nikita.ppv@gmail.com (Nikita Popov)

--089e013d171caba7a60521ece476
Content-Type: text/plain; charset=UTF-8

On Mon, Oct 12, 2015 at 8:24 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi Nikita,
>
> I think the effect of the remaining patch is negligible.
> It disables things, that shouldn't work by design, didn't work in fact and
> leaded to crashes.
> It might work only in some cases and only because of luck.
>
> So, I think it's better to commit this before next RC.
> Anatol is going to start rolling it on Tuesday.
>

Done.

> It would be great, if we stop any commits into PHP-7.0 except for
critical fixes now

Maybe keep PHP-7.0 open (or as open as release branches usually are), but
from now on only cherry-pick critical fixes into PHP-7.0.0 (instead of
merging everything)?

Nikita

--089e013d171caba7a60521ece476--