Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88709
Return-Path: <ircmaxell@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 76221 invoked from network); 6 Oct 2015 21:21:06 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 6 Oct 2015 21:21:06 -0000
Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.194 as permitted sender)
X-PHP-List-Original-Sender: ircmaxell@gmail.com
X-Host-Fingerprint: 209.85.212.194 mail-wi0-f194.google.com  
Received: from [209.85.212.194] ([209.85.212.194:32774] helo=mail-wi0-f194.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 76/18-19251-14B34165 for <internals@lists.php.net>; Tue, 06 Oct 2015 17:21:06 -0400
Received: by wicuu12 with SMTP id uu12so316648wic.0
        for <internals@lists.php.net>; Tue, 06 Oct 2015 14:21:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=GFZruu1O+bVUkoLyNHC7kFDl7d0RGKYEHWpEGeEznj4=;
        b=sFKfXJZCi7ZkXhNrIYyFn3qHSTJ3gVBJfGkacv1EAXa+1CBXpIOVq5pRdpDW/Lk0AB
         EXnp39BUIDwh2djjh1phZ32eVwqv3wLaSIdKOGL5urFdLFVPXAOhFIjUETjbwzdh0TEo
         /TIx44I2ce3qoX/03YzTv4P+lW6eHoUukzaM1U0QNNqukVXqnKPBUfRBANdSwWeDgjWS
         XAF4QeXAU0FDAzaaIURjRhtjd26rY17cJRonzRSJlIGyoIqRVqap2eQOdQA2hfjj/4Pa
         mcpSL/h8XvgAbqlTAQ04ZoQpTLXMl1IhaSVRC2d/PrhxkyGWRmpTucX0Uo0b4hDUK503
         M0Xg==
MIME-Version: 1.0
X-Received: by 10.194.5.35 with SMTP id p3mr46459315wjp.132.1444166462835;
 Tue, 06 Oct 2015 14:21:02 -0700 (PDT)
Received: by 10.28.55.18 with HTTP; Tue, 6 Oct 2015 14:21:02 -0700 (PDT)
In-Reply-To: <CAEYWF=7JWgXDmwACKUJ7innztxSudAev5eZ11mFcfCJJwiZKgw@mail.gmail.com>
References: <CAEYWF=7JWgXDmwACKUJ7innztxSudAev5eZ11mFcfCJJwiZKgw@mail.gmail.com>
Date: Tue, 6 Oct 2015 17:21:02 -0400
Message-ID: <CAAyV7nFZob35+3ot44gNPONLd+=dU9daHSshY_ynPZZB9i3eGA@mail.gmail.com>
To: bishop@php.net
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Remove name mangling? (when creating variables from
 external sources)
From: ircmaxell@gmail.com (Anthony Ferrara)

Hey,

On Tue, Oct 6, 2015 at 4:38 PM, Bishop Bettini <bishop@php.net> wrote:
> Hi!
>
> Currently dots and spaces are converted to underscores when pulling them in
> from HTML:
>
>     <!-- php will only see two submitted values, b/c of mangling -->
>     <input type='file' name='file5.1' />
>     <input type='file' name='file5 1' />
>     <input type='file' name='file5_1' />
>     <input type='text' name='file5.1' />
>     <input type='text' name='file5 1' />
>     <input type='text' name='file5_1' />
>
> Ostensibly[1], names were mangled to support import_request_variables and
> register_globals.  But curiously other characters that would create an
> invalid variable aren't mangled:
>
>     <input type='text' name='file5$1' /> <!-- why not mangle $ also? -->
>
> There are already two bug requests out there asking to remove this behavior
> or expose the original name: #34882 and #42055
>
> Since 5.4.0 removed both import_request_variables and register_globals,
> does this mangling serve any purpose?  If not, can we remove it?
>
>
> [1] http://php.net/manual/en/language.variables.external.php
> [2] https://bugs.php.net/bug.php?id=34882
> [3] https://bugs.php.net/bug.php?id=42055

I'm all for this. Mangling has always seemed ...weird... Pulling it
out is awesome.

However, it also would be a pretty non-trivial BC break for people who
rely on the mangling. This would be likely something for 8?

Anthony