Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88708
Return-Path: <bishop.bettini@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71463 invoked from network); 6 Oct 2015 20:38:55 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 6 Oct 2015 20:38:55 -0000
Authentication-Results: pb1.pair.com smtp.mail=bishop.bettini@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=bishop.bettini@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
X-PHP-List-Original-Sender: bishop.bettini@gmail.com
X-Host-Fingerprint: 209.85.212.177 mail-wi0-f177.google.com  
Received: from [209.85.212.177] ([209.85.212.177:33157] helo=mail-wi0-f177.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 4A/47-19251-E5134165 for <internals@lists.php.net>; Tue, 06 Oct 2015 16:38:55 -0400
Received: by wiclk2 with SMTP id lk2so184997932wic.0
        for <internals@lists.php.net>; Tue, 06 Oct 2015 13:38:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:reply-to:sender:date:message-id:subject:from:to
         :content-type;
        bh=X7l8zrPIDldJ3wu7FP9YMCjfxsbtixxDxdyG4oYm/eM=;
        b=h8d6InY0jD6gzMg6gy+zVG7zUNkTsZjXXJ7Kw90TAQp8jLOy3GdpFEfWU32/8YGmzk
         eYH9FfIoDqUTLgZ0S8OMyJUEkWy64AAIXuqhOO/WbSPU35QazzYFvO0jXk9cTi/0QQG4
         /2Cd+F3U6JnEQvXCeYDS5m5SauVzfwedw6brBTsg3sfx88R+7EES/OMzhXgf9X4aQS6a
         k74t7IeS4uM6Za2k0t+g8wYgf0HAw3gzaMIp1fASJa9lJx9fnkPdkT9RzGm7q/288dyb
         mKw+KCYb/HOhzQMZ58eF9xOP/sHREIoMG8lGV9yhV5FB+GdlGoNs7Z9DIW5uW0SxTItA
         bJWA==
MIME-Version: 1.0
X-Received: by 10.180.106.98 with SMTP id gt2mr20278818wib.31.1444163931758;
 Tue, 06 Oct 2015 13:38:51 -0700 (PDT)
Reply-To: bishop@php.net
Sender: bishop.bettini@gmail.com
Received: by 10.194.110.72 with HTTP; Tue, 6 Oct 2015 13:38:51 -0700 (PDT)
Date: Tue, 6 Oct 2015 16:38:51 -0400
X-Google-Sender-Auth: SeONE9te_WhwCfiqlrQ7jA6w-0U
Message-ID: <CAEYWF=7JWgXDmwACKUJ7innztxSudAev5eZ11mFcfCJJwiZKgw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04428f1c2666b10521759e31
Subject: Remove name mangling? (when creating variables from external sources)
From: bishop@php.net (Bishop Bettini)

--f46d04428f1c2666b10521759e31
Content-Type: text/plain; charset=UTF-8

Hi!

Currently dots and spaces are converted to underscores when pulling them in
from HTML:

    <!-- php will only see two submitted values, b/c of mangling -->
    <input type='file' name='file5.1' />
    <input type='file' name='file5 1' />
    <input type='file' name='file5_1' />
    <input type='text' name='file5.1' />
    <input type='text' name='file5 1' />
    <input type='text' name='file5_1' />

Ostensibly[1], names were mangled to support import_request_variables and
register_globals.  But curiously other characters that would create an
invalid variable aren't mangled:

    <input type='text' name='file5$1' /> <!-- why not mangle $ also? -->

There are already two bug requests out there asking to remove this behavior
or expose the original name: #34882 and #42055

Since 5.4.0 removed both import_request_variables and register_globals,
does this mangling serve any purpose?  If not, can we remove it?


[1] http://php.net/manual/en/language.variables.external.php
[2] https://bugs.php.net/bug.php?id=34882
[3] https://bugs.php.net/bug.php?id=42055

--f46d04428f1c2666b10521759e31--