Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88667
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.160.177 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAB6YZuxOzak8ODh=f1qf6hMkm=xYSNmFarWcw-k=3UOfY4ZXzQ@mail.gmail.com>
References: <CA+kxMuSFP=vooMzCYMapTsis6RGBVd-T4YM9z3YuxgF3Rcj6EQ@mail.gmail.com>
	<CADyq6s+16pW=w7S-djTyidxX7pN58Qxxuoyr2FMLDgmicVjfoA@mail.gmail.com>
	<CAB6YZuxOzak8ODh=f1qf6hMkm=xYSNmFarWcw-k=3UOfY4ZXzQ@mail.gmail.com>
Date: Sun, 4 Oct 2015 15:36:42 +0000
Message-ID: <CA+kxMuS3SS1BaBcSjOi9g0iYp3WLhn7NPCeB16ZD+4M=1aus3w@mail.gmail.com>
To: =?UTF-8?Q?Pavel_Kou=C5=99il?= <pajousek@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION]: Closure from callable
From: danack@basereality.com (Dan Ackroyd)

Hi Pavel,

On 4 October 2015 at 11:31, Pavel Kou=C5=99il <pajousek@gmail.com> wrote:
>
> and what about changing the empty ctor of Closure to
> __construct(callable $callable)?
>
> And the usage would be new Closure([$this, 'abc']);?
>

I'm going to change the RFC to use the 'named constructor'
Closure::fromCallable which should address the naming concerns.

IMO, default constructors are bad and I encourage people to stop using
them. In this case they are bad as they can't be passed as a callable.
Either 'closure' or 'Closure::fromCallable can be passed as a
callable:

function createClosure($callable, $name) {
    // do stuff
    return $callable($name);
}

foo('closure', 'bar');
foo([Closure::class, 'fromCallable'], 'bar');
foo('librarySpecificClosureGenerator', 'bar');

In addition, it's inappropriate to use default constructors in a class
where it is even slightly likely that you are going to have more than
one way of constructing that object, as you then have to hack around
the fact that you want to create other named constructors that don't
call the default constructor.

cheers
Dan