Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88584
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.178 as permitted sender)
MIME-Version: 1.0
Date: Wed, 30 Sep 2015 13:39:26 -0700
Message-ID: <CADbOR2hf_eDzRdMWuKs5imn3PDbBo52Fm62=ShDOt49H_gpmbw@mail.gmail.com>
To: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113f3cd42da4ab0520fced0c
Subject: good example of unserialization fundamentals?
From: zardozrocks@gmail.com (j adams)

--001a113f3cd42da4ab0520fced0c
Content-Type: text/plain; charset=UTF-8

I have completed a first draft of serialization functionality which is
intended to be an updated to amfext. It's on github[0] if anyone is
interested. I would now like to write all the unserialization routines and
would like some suggestions from experienced php devs. I've been reading
Sara Golemon's book, but am still a little unsure.

In particular, I want my userland function, amf_decode to accept as a
parameter a string (and possibly other args). This is not so difficult but
I must call upon another function, php_amf_decode, which needs to be able
to handle recursive calls.

Something like this:

// userland function
static PHP_FUNCTION(amf_decode) {
    char *buf; // char buffer, contains serialize data string
    int buf_len, buf_cursor=0; // the length of the buffer
    long flags = 0;

    if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s|l", &buf,
&buf_len, &flags) == FAILURE) {
        return;
    }

    if (!buf_len) {
        RETURN_NULL();
    }

    php_amf_decode(return_value, buf, buf_len, &buf_cursor, flags
TSRMLS_CC);
}

// proposed recursive decoding function
PHP_AMF_API void php_amf_decode(zval *return_value, char *buf, int buf_len,
int *buf_cursor, long flags TSRMLS_DC)
{

    // is it safe to use these macros in this recursive function?
    RETVAL_BOOL(1);

    // or this
    RETURN_LONG(42);


}


[0] https://github.com/sneakyimp/amfext

--001a113f3cd42da4ab0520fced0c--