Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88525
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.46 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <009101d0f95d$e7492670$b5db7350$@belski.net>
References: <CAGa2bXbBhJtKo2tk+6udr2UHJFe46fbcw2-+yatru4pO1CuXxw@mail.gmail.com>
 <CAGa2bXZfRP_eV954mH+i08jvqtReJtip-oMP6ms8y8J_QNigJA@mail.gmail.com>
 <CAJW__o0J=JeVbTdK3xu6F8uDLn0Psw-_4c1_anz0O6=D+35KBQ@mail.gmail.com>
 <CAGa2bXY3wieKd90ypgYSZ3nZgLOtELcnt+cuuGorm4jDy7U_3A@mail.gmail.com>
 <023701d0f4a4$a0da4f60$e28eee20$@belski.net> <CAGa2bXYeMq5MuGiGUqnTZUgAK4xUZe6wkpqcijnU_FjjLiVwsw@mail.gmail.com>
 <004701d0f892$05fdb0d0$11f91270$@belski.net> <CAEKnhAHxZx3Qzegkhq1L787fzpgYFDe_JyfxksGSp-Sp7HH7yw@mail.gmail.com>
 <009101d0f95d$e7492670$b5db7350$@belski.net>
Date: Mon, 28 Sep 2015 17:28:27 +0900
Message-ID: <CAGa2bXaDGTGSODhms5v=c6esZZsHSeq_YtOGysffCh296FC9xw@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Jakub Zelenka <bukka@php.net>, Kalle Sommer Nielsen <kalle@php.net>, 
	PHP internals list <internals@lists.php.net>, Anatol Belski <anatol.php@belski.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi all and Ferenc,

On Mon, Sep 28, 2015 at 4:51 AM, Anatol Belski <anatol.php@belski.net> wrot=
e:
>> -----Original Message-----
>> From: jakub.php@gmail.com [mailto:jakub.php@gmail.com] On Behalf Of Jaku=
b
>> Zelenka
>> > Exactly, so my question was - why it still needs to do "if (mode =3D=
=3D 0)
>> > ndigit =3D 17;" in snprintf at the place I've linked? It won't have an=
y
>> > effect as zend_dtoa will ignore it :)
>> >
>>
>> As I said in the PR some time ago, it's not used by dtoa for mode 0 but =
it's still
>> used by php_gcvt for checking if exponential or decimal notation should =
be
>> used. See
>>
>> https://github.com/php/php-
>> src/blob/250938e2d35fc54161a18167b7901c5e3b574371/main/snprintf.c#L163
>>
> Ah, I see it now. The patch is quite sparse, so have to check the whole f=
unctions. Thanks for the explanations.
>
> For 7.0 raising the precision INIs to max supported were probably OK, but=
 no new INI options should be added. And IMHO, there should be only one INI=
 option change, and preferably full patch with json_precision in 7.1 and no=
t touching other branches (the simplest solution). As it seems, one sees it=
 critical to start using 17 digits in 7.0 - then probably vote were eligibl=
e (whereby I wouldn't see it critical). But then IMHO - switch to serialize=
_precision in 7.0 and keep the name for 7.1 with full patch. Though please =
be aware that times are going fast, if you decide to put something 7.0 rela=
ted to the vote, be sure the results stand till RC5.

Thank you for explanation, Jakub.

Ferenc, are you OK with the JSON serialize precision change?
i.e. Use PG(serialize_precision) rather than EG(precision) when
json_serialize() is called.
If yes, I'll prepare the patch and start the vote immediately.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net