Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88506
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEYWF=4ZrgX1Z8Qp9Jv=HW3dh0B6O-DWKvQRwUt1CvqrWLyg7Q@mail.gmail.com>
References: <BLU436-SMTP156E8D7D141A710541FCA0FE2450@phx.gbl>
	<CAEYWF=4ZrgX1Z8Qp9Jv=HW3dh0B6O-DWKvQRwUt1CvqrWLyg7Q@mail.gmail.com>
Date: Sat, 26 Sep 2015 09:06:18 +0200
Message-ID: <CAB6YZuz8RWeL04Y2k0i0CHjty9nH9gR7VZsOs+MxmsJUMRfcOQ@mail.gmail.com>
To: bishop@php.net
Cc: Bob Weinand <bobwei9@hotmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [VOTE] Short Closures
From: pajousek@gmail.com (=?UTF-8?Q?Pavel_Kou=C5=99il?=)

On Fri, Sep 25, 2015 at 9:44 PM, Bishop Bettini <bishop@php.net> wrote:
> Hi,
>
> On Mon, Sep 21, 2015 at 9:59 PM, Bob Weinand <bobwei9@hotmail.com> wrote:
>
>> So, before I start the vote, just two quick notes:
>> I've added two notes about the statement syntax and the single variable
>> use.
>> Though a few people complained, I'm not switching to the =3D=3D> operato=
r, as
>> I noticed many people expected typehints to work (they don't due to pars=
er
>> limitations) when they compared to Hack's short Closures. It also allows=
 us
>> to differ syntax-wise [e.g. for typehints] from Hack without causing any
>> confusion later. Which should be the smartest choice: Avoid conflicts. (=
If
>> anyone strongly feels against that, he may vote no, but I would like to =
not
>> bikeshed that in this Vote thread, but leave it free for eventual actual
>> issues.)
>>
>
> I voted "no" because I'm against the automatic use () and introducing a n=
ew
> symbol.
>
> An earlier short closure RFC [1] supports explicit import, and I would wa=
nt
> to see explicit import mandated.  And rather than inventing a new symbol,
> why not just re-purpose 'as' in this context?
>
> function sumEventScores($events, $scores) {
>     $types =3D array_map($event as $event['type'], $events);
>     return array_reduce($types, ($sum, $type) as $sum + $scores[$type]);
> }
>
> 'use' is already purposed in three places, I don't see why 'as' can't als=
o
> be in three places.  Though I've not checked the engine source to see the
> actual effort, so this just may be astronaut architecting.
>
> Anyway, thanks to Bob for his hard work pulling this together and everyon=
e
> for arguing it out.  That's what makes PHP great.
>
> Sincerely,
> bishop
>
> [1]: https://wiki.php.net/rfc/short-syntax-for-anonymous-function

Hello,

I can't grasp the "intent" behind the "as". Reading it like "parameter
$sum and parameter type as $sum + $scores[$type]" seems pretty
confusing to me.

Also, if we look at the example from RFC - with your "as" suggestion,
it would look like this:

function reduce(callable $fn) {
    return $initial as $input as {
        $accumulator =3D $initial;
        foreach ($input as $value) {
            $accumulator =3D $fn($accumulator, $value);
        }
        return $accumulator;
    };
}

This doesn't seem like the right way to me. :(

Regards
Pavel Kou=C5=99il