Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:88470 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 1721 invoked from network); 24 Sep 2015 10:01:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Sep 2015 10:01:14 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:34794] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FF/87-33598-9E9C3065 for ; Thu, 24 Sep 2015 06:01:13 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id 3DF1210C641; Thu, 24 Sep 2015 11:01:09 +0100 (BST) Date: Thu, 24 Sep 2015 11:01:09 +0100 (BST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Sean DuBois cc: internals@lists.php.net In-Reply-To: <20150923203939.GA40539@3006.local> Message-ID: References: <20150923203939.GA40539@3006.local> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] zend_parse_parameters changes not fully documented in phpng-upgrading, PR to fix existing tools From: derick@php.net (Derick Rethans) On Wed, 23 Sep 2015, Sean DuBois wrote: > Hey list, > > 'l' had a change 'long' -> 'zend_long' and 's' had a change 'int' -> > 'size_t'. > > These two changes are really hard to catch when porting an extension, > nothing complains at compile time, you don't get segfaults when > calling zend_parse* but usually later and it is platform dependent > (Windows for me when porting phpredis) I am lucky that I had a > developer (Jan-E) help me with this, or I would have pushed the > extension out the door broken for many people. > > A.) Can someone merge https://github.com/php/php-src/pull/1521 this is > currently the only solution I know of to catch these things in an > automated way I didn't know this script existed! I've added a few comments. Once resolved, I'll merge it. > B.) Can someone give me access to https://wiki.php.net/phpng-upgrading > so I can document this What's your wiki username? > C.) Has there ever been a conversation about improving extension > building so that authors don't have to go out of their way to catch > these things? I would really like to see phpize kick out a Makefile > that in the process of building/testing would raise alerts about this. Conversations yes, solutions, no. I'd be awesome to have this though. cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug Posted with an email client that doesn't mangle email: alpine