Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88467
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.215.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAMbn9ZEKG0c=xaDiN5hzxC2H+rvL2pszUh3-+D+n+QXvopejbQ@mail.gmail.com>
References: <CAMbn9ZEHXT7SPCo1ai4FpVfjR7X+vPe+uEOKwY13VDdJR4g6+g@mail.gmail.com>
	<CA+9eiLsu2K9v-89w8RbHvyd=yH+Nu_tQLnzucRWhr1CzdhGciA@mail.gmail.com>
	<CAMbn9ZEKG0c=xaDiN5hzxC2H+rvL2pszUh3-+D+n+QXvopejbQ@mail.gmail.com>
Date: Thu, 24 Sep 2015 11:00:35 +0300
Message-ID: <CA+9eiLtHFFXFqOA18VJGKULgqHqjx=krPWQxBrSnb-V2MogQ1w@mail.gmail.com>
To: Matt Ficken <themattficken@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, "dmitry@php.net" <dmitry@php.net>, 
	Xinchen Hui <laruence@php.net>
Content-Type: multipart/alternative; boundary=001a11c2ae0e3e6001052079a05a
Subject: Re: Windows OpCache bug fix
From: dmitry@zend.com (Dmitry Stogov)

--001a11c2ae0e3e6001052079a05a
Content-Type: text/plain; charset=UTF-8

hi Matt,

Thanks.
I also moved the exit condition to be before Sleep().
This should prevent race condition on last iteration (after unlocked sleep
process should try to reattach).
Committed to PHP-7.0 and master.

http://git.php.net/?p=php-src.git;a=commitdiff;h=262160e0e9919dce914df2f0643c4b16ca137454

If this really works, we should backport this into php-5.* as well.

Thanks. Dmitry.

On Thu, Sep 24, 2015 at 8:34 AM, Matt Ficken <themattficken@gmail.com>
wrote:

> Ok, I have a new PR just to unlock around Sleep():
> https://github.com/php/php-src/pull/1536
>
> Just by unlocking around Sleep() the OpenFileMapping loop will work.
> Holding the lock in that loop will not only block detach_segments() in
> other PHP processes but also reattaching in accel_startup().
>
> Checking the base address used when this issue occurs during some of my
> stress testing, most of the time the base address used is the first in
> vista_mapping_base_set. Its typically the timing between the locking and
> mapped file operations between processes more often than the base address
> selection.
>
> Especially ASLR, also PECL DLLs, and other factors will still cause this
> issue occasionally, but this fixes a majority of my occurrences.
>
> Regards
> -M
>
>
> On Wed, Sep 23, 2015 at 2:04 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Matt,
>>
>> It looks like with your patch, the same file may be mapped to different
>> virtual addresses of different processes and this won't work.
>> I think usage of vista_mapping_base_set[] in your patch is wrong.
>>
>> Do I understand properly, that zend_shared_alloc_unlock/lock_win32()
>> around Sleep() is the main part of the patch?
>>
>> Please, next time, try to make PR diffs as small as possible (without
>> messing real fix with formatting and rearranging changes).
>>
>> Thanks. Dmitry.
>>
>>
>>
>> On Wed, Sep 23, 2015 at 10:10 AM, Matt Ficken <themattficken@gmail.com>
>> wrote:
>>
>>> I want to increase visibility for my PR 1531,
>>> https://github.com/php/php-src/pull/1531, my patch for fixing an
>>> intermittent OpCache issue on Windows.
>>>
>>> Details, etc... are on the PR.
>>>
>>> Regards
>>> -M
>>>
>>
>>
>

--001a11c2ae0e3e6001052079a05a--