Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88431
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.50 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAMbn9ZEHXT7SPCo1ai4FpVfjR7X+vPe+uEOKwY13VDdJR4g6+g@mail.gmail.com>
References: <CAMbn9ZEHXT7SPCo1ai4FpVfjR7X+vPe+uEOKwY13VDdJR4g6+g@mail.gmail.com>
Date: Wed, 23 Sep 2015 12:04:07 +0300
Message-ID: <CA+9eiLsu2K9v-89w8RbHvyd=yH+Nu_tQLnzucRWhr1CzdhGciA@mail.gmail.com>
To: Matt Ficken <themattficken@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, "dmitry@php.net" <dmitry@php.net>, 
	Xinchen Hui <laruence@php.net>
Content-Type: multipart/alternative; boundary=001a11438b28ab57960520666535
Subject: Re: Windows OpCache bug fix
From: dmitry@zend.com (Dmitry Stogov)

--001a11438b28ab57960520666535
Content-Type: text/plain; charset=UTF-8

Hi Matt,

It looks like with your patch, the same file may be mapped to different
virtual addresses of different processes and this won't work.
I think usage of vista_mapping_base_set[] in your patch is wrong.

Do I understand properly, that zend_shared_alloc_unlock/lock_win32() around
Sleep() is the main part of the patch?

Please, next time, try to make PR diffs as small as possible (without
messing real fix with formatting and rearranging changes).

Thanks. Dmitry.



On Wed, Sep 23, 2015 at 10:10 AM, Matt Ficken <themattficken@gmail.com>
wrote:

> I want to increase visibility for my PR 1531,
> https://github.com/php/php-src/pull/1531, my patch for fixing an
> intermittent OpCache issue on Windows.
>
> Details, etc... are on the PR.
>
> Regards
> -M
>

--001a11438b28ab57960520666535--