Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:88429 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45287 invoked from network); 23 Sep 2015 08:27:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Sep 2015 08:27:56 -0000 Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error) X-PHP-List-Original-Sender: anatol.php@belski.net X-Host-Fingerprint: 85.214.73.107 klapt.com Received: from [85.214.73.107] ([85.214.73.107:44319] helo=h1123647.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E8/23-10948-78262065 for ; Wed, 23 Sep 2015 04:27:52 -0400 Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006) id 981C66D2002; Wed, 23 Sep 2015 10:27:48 +0200 (CEST) Received: from w530phpdev (pD9FD2FC3.dip0.t-ipconnect.de [217.253.47.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id 0C49C6D2002; Wed, 23 Sep 2015 10:27:45 +0200 (CEST) To: "'Matt Ficken'" , "'PHP Internals'" Cc: , References: In-Reply-To: Date: Wed, 23 Sep 2015 10:27:44 +0200 Message-ID: <000001d0f5d9$ba569850$2f03c8f0$@belski.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQHEZydHUDlzPZMYkUAa9TBZ2Cu8iZ5i1R4Q Content-Language: en-us Subject: RE: [PHP-DEV] Windows OpCache bug fix From: anatol.php@belski.net ("Anatol Belski") Hi Matt, > -----Original Message----- > From: Matt Ficken [mailto:themattficken@gmail.com] > Sent: Wednesday, September 23, 2015 9:10 AM > To: PHP Internals > Cc: dmitry@php.net; laruence@php.net > Subject: [PHP-DEV] Windows OpCache bug fix >=20 > I want to increase visibility for my PR 1531, = https://github.com/php/php- > src/pull/1531, my patch for fixing an intermittent OpCache issue on = Windows. >=20 > Details, etc... are on the PR. >=20 thanks for the patch. It's great to fix that "base address" issue in = PHP-7.0 at least. It would probably make sense to backport it to 5.6 = later. One minor comment though - you shouldn't use C++ comments there = according to the coding styles. Regards Anatol