Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88419
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <BLU436-SMTP119DBD86D69A26D18963ACDE2450@phx.gbl>
References: <BLU436-SMTP156E8D7D141A710541FCA0FE2450@phx.gbl>
	<CA+9eiLtfxLNCMra1Xj9PEhAFZB+h903AK1rmWSQAH4SqQm2qCQ@mail.gmail.com>
	<CAL=_i_=wR5e3Bv++pKwMZcBJoF+0tVsXuRHnZYpa4wnq+cBdWg@mail.gmail.com>
	<CA+9eiLtVxiohBkQeDbP_aDtTdwQD_8p46gT73bikQTKKi8rHSQ@mail.gmail.com>
	<BLU436-SMTP1607EC07C73BB9E5D5AB95EE2450@phx.gbl>
	<CA+9eiLv3ge6Ur76DS8kjW2ZFV3ciLLhbDfvWXKu3FeR=e1CLdw@mail.gmail.com>
	<BLU436-SMTP119DBD86D69A26D18963ACDE2450@phx.gbl>
Date: Tue, 22 Sep 2015 22:24:34 +0300
Message-ID: <CA+9eiLsTH7fwvgsuAjzR87jQJL7Pwt+FtD8oK_MdD=9HrFaqMA@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: Joe Watkins <pthreads@pthreads.org>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11438b28b7fd0b05205af2b6
Subject: Re: [PHP-DEV] [RFC] [VOTE] Short Closures
From: dmitry@zend.com (Dmitry Stogov)

--001a11438b28b7fd0b05205af2b6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 22, 2015 at 9:24 PM, Bob Weinand <bobwei9@hotmail.com> wrote:

>
> Am 22.09.2015 um 20:05 schrieb Dmitry Stogov <dmitry@zend.com>:
>
> The current PHP version emits two warning on similar constructs, and this
> is explainable because we explicitly "use" $y.
>
> $ sapi/cli/php -r 'function foo(){(function($x) use ($y){$y=3D3; return
> $y+$x;})(5);return $y;} var_dump(foo());'
> PHP Notice:  Undefined variable: y in Command line code on line 1
>
> PHP Notice:  Undefined variable: y in Command line code on line 1
>
> NULL
>
> Thanks. Dmitry.
>
>
> Well, yes. But that obviously needs alternate handling here as we don't
> have full analysis to look at whether we'd need to import or not. Hence w=
e
> just are importing everything if it's used in Closure scope and defined i=
n
> parent scope.
>
> Because we obviously don't want this to emit a notice:
>
> function foo() {
>     return ($x ~> {
>         $y =3D 2;
>         return $x + $y;
>     })(10);
> }
>
> Else it'd be totally impossible to define any variables...
>
> Also, the long form sets $y to NULL in the Closure (we just have two
> notices there because you return $y; too=E2=80=A6 if you remove that, you=
'll be
> left with just one notice.
>

I saw, you have fixed that warning on implicit use.

Thanks. Dmitry.


>
> Bob
>

--001a11438b28b7fd0b05205af2b6--