Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88417
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.111.154 as permitted sender)
Message-ID: <BLU436-SMTP119DBD86D69A26D18963ACDE2450@phx.gbl>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_F137B1EB-96F5-44A9-BB17-2B22B2160C42"
MIME-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
In-Reply-To: <CA+9eiLv3ge6Ur76DS8kjW2ZFV3ciLLhbDfvWXKu3FeR=e1CLdw@mail.gmail.com>
Date: Tue, 22 Sep 2015 20:24:33 +0200
CC: Joe Watkins <pthreads@pthreads.org>,
 PHP internals <internals@lists.php.net>
References: <BLU436-SMTP156E8D7D141A710541FCA0FE2450@phx.gbl> <CA+9eiLtfxLNCMra1Xj9PEhAFZB+h903AK1rmWSQAH4SqQm2qCQ@mail.gmail.com> <CAL=_i_=wR5e3Bv++pKwMZcBJoF+0tVsXuRHnZYpa4wnq+cBdWg@mail.gmail.com> <CA+9eiLtVxiohBkQeDbP_aDtTdwQD_8p46gT73bikQTKKi8rHSQ@mail.gmail.com> <BLU436-SMTP1607EC07C73BB9E5D5AB95EE2450@phx.gbl> <CA+9eiLv3ge6Ur76DS8kjW2ZFV3ciLLhbDfvWXKu3FeR=e1CLdw@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Short Closures
From: bobwei9@hotmail.com (Bob Weinand)

--Apple-Mail=_F137B1EB-96F5-44A9-BB17-2B22B2160C42
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"


> Am 22.09.2015 um 20:05 schrieb Dmitry Stogov <dmitry@zend.com>:
>=20
> The current PHP version emits two warning on similar constructs, and =
this
> is explainable because we explicitly "use" $y.
>=20
> $ sapi/cli/php -r 'function foo(){(function($x) use ($y){$y=3D3; =
return
> $y+$x;})(5);return $y;} var_dump(foo());'
> PHP Notice:  Undefined variable: y in Command line code on line 1
>=20
> PHP Notice:  Undefined variable: y in Command line code on line 1
>=20
> NULL
>=20
> Thanks. Dmitry.

Well, yes. But that obviously needs alternate handling here as we don't =
have full analysis to look at whether we'd need to import or not. Hence =
we just are importing everything if it's used in Closure scope and =
defined in parent scope.

Because we obviously don't want this to emit a notice:

function foo() {
    return ($x ~> {
        $y =3D 2;
        return $x + $y;
    })(10);
}

Else it'd be totally impossible to define any variables...

Also, the long form sets $y to NULL in the Closure (we just have two =
notices there because you return $y; too=E2=80=A6 if you remove that, =
you'll be left with just one notice.

Bob=

--Apple-Mail=_F137B1EB-96F5-44A9-BB17-2B22B2160C42--