Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88390
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Yasuo Ohgaki'" <yohgaki@ohgaki.net>,
	"'Kalle Sommer Nielsen'" <kalle@php.net>
Cc: "'Ferenc Kovacs'" <tyra3l@gmail.com>,
	<internals@lists.php.net>
References: <CAGa2bXbBhJtKo2tk+6udr2UHJFe46fbcw2-+yatru4pO1CuXxw@mail.gmail.com> <CAGa2bXZfRP_eV954mH+i08jvqtReJtip-oMP6ms8y8J_QNigJA@mail.gmail.com> <CAJW__o0J=JeVbTdK3xu6F8uDLn0Psw-_4c1_anz0O6=D+35KBQ@mail.gmail.com> <CAGa2bXY3wieKd90ypgYSZ3nZgLOtELcnt+cuuGorm4jDy7U_3A@mail.gmail.com>
In-Reply-To: <CAGa2bXY3wieKd90ypgYSZ3nZgLOtELcnt+cuuGorm4jDy7U_3A@mail.gmail.com>
Date: Mon, 21 Sep 2015 21:35:06 +0200
Message-ID: <023701d0f4a4$a0da4f60$e28eee20$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIuTDCwWc2HF4xophrruCZqRmQ9xAK8kBvIAb/EVTQDP8Pfqp1Oyf9A
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value
From: anatol.php@belski.net ("Anatol Belski")

Hi Yasuo,

> -----Original Message-----
> From: yohgaki@gmail.com [mailto:yohgaki@gmail.com] On Behalf Of Yasuo
> Ohgaki
> Sent: Sunday, September 20, 2015 11:49 PM
> To: Kalle Sommer Nielsen <kalle@php.net>
> Cc: Anatoliy Belsky <ab@php.net>; Ferenc Kovacs <tyra3l@gmail.com>;
> internals@lists.php.net
> Subject: Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value
>=20
> Hi Anatol and Ferenc,
>=20
> On Sat, Sep 19, 2015 at 7:15 AM, Kalle Sommer Nielsen <kalle@php.net> =
wrote:
> > I'm sorry I have not caught this any earlier, but even without
> > consulting with Anatol, I'm not keen on adding this into 7.0, we are
> > in RC stage, and I want us to focus on a stable release instead of
> > adding more potential issues, I suggest you target 7.1 instead in =
the
> > RFC.
> >
> > (Ferenc and Anatol cc'd)
>=20
> I was expecting this kind of reply for this RFC.
> What do you think?
>=20
> This RFC contains JSON float value precision change for PHP 5.6 so =
that PHP
> would not loose floating number information, as well as more precise =
float
> handling option for PHP 7.0.
>=20
> FYI, var_dump()'s float precision was changed to use =
serialize_precision as bug
> fix before.
>=20
Thanks for the ping. IMHO this is the stuff for 7.1. I actually saw the =
discussions previously, but was rather thinking you was targeting 7.1 as =
that was already the time of the feature freeze.

Please keep in mind that we effectively have two RCs to do the remaining =
stabilizations. And we probably should as much as possible. Because this =
patch it's rather an enhancement to the current functionality which is =
not indeed broken - I wouldn't see it as critical for 7.0. It should be =
voted (and discussed if necessary) for 7.1, so we don't loop away from =
our current situation.

BTW I also had a comment there in the PR about =
https://github.com/php/php-src/pull/1455/files#diff-c84859666ff690a113d55=
ef1899d8bf4R149 - so if mode 0 ignores ndigits, why set it to 17 (or =
anything else). Seems like an unnecessary action, but snprintf is used =
quite frequently. But just as a notice on the side.

Regards

Anatol