Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88263
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Adam Harvey'" <aharvey@php.net>,
	"'Dmitry Stogov'" <dmitry@php.net>
Cc: "'PHP internals'" <internals@lists.php.net>,
	"'Anatoliy Belsky'" <ab@php.net>,
	"'Kalle Sommer Nielsen'" <kalle@php.net>,
	"'Ferenc Kovacs'" <tyrael@php.net>
References: <CADajX4Du43JtWGGKURsQWxM7CZs6+3yv+0L1uJVnZr9cV5Ct1w@mail.gmail.com>
In-Reply-To: <CADajX4Du43JtWGGKURsQWxM7CZs6+3yv+0L1uJVnZr9cV5Ct1w@mail.gmail.com>
Date: Wed, 16 Sep 2015 23:31:52 +0200
Message-ID: <014401d0f0c7$1c6120f0$552362d0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIeaxaGxbE8e4tlKMWqZDrI/Om5Z52klKag
Content-Language: en-us
Subject: RE: ABI break? (was: [PHP-CVS] com php-src: Don't inline "slow" and rarely used functions.: Zend/zend_alloc.c Zend/zend_alloc.h)
From: anatol.php@belski.net ("Anatol Belski")

Hi Adam,

> -----Original Message-----
> From: adam@adamharvey.name [mailto:adam@adamharvey.name] On Behalf
> Of Adam Harvey
> Sent: Wednesday, September 16, 2015 3:08 AM
> To: Dmitry Stogov <dmitry@php.net>
> Cc: PHP internals <internals@lists.php.net>; Anatoliy Belsky =
<ab@php.net>; Kalle
> Sommer Nielsen <kalle@php.net>; Ferenc Kovacs <tyrael@php.net>
> Subject: ABI break? (was: [PHP-CVS] com php-src: Don't inline "slow" =
and rarely
> used functions.: Zend/zend_alloc.c Zend/zend_alloc.h)
>=20
> On 9 September 2015 at 03:42, Dmitry Stogov <dmitry@php.net> wrote:
> > Commit:    ac83eaef1097552065395872c69b77dcab2919b1
> > Author:    Dmitry Stogov <dmitry@zend.com>         Wed, 9 Sep 2015 =
13:42:35
> +0300
> > Parents:   6d885e395ca33fef28c5b84b7cfd59885aaa6e2d
> > Branches:  master
> >
> > Link:       http://git.php.net/?p=3Dphp-
> src.git;a=3Dcommitdiff;h=3Dac83eaef1097552065395872c69b77dcab2919b1
> >
> > Log:
> > Don't inline "slow" and rarely used functions.
>=20
> This commit appears to have broken binary compatibility for extensions =
that
> make persistent memory allocations, since __zend_malloc is now a real =
function
> and not inlined: such an extension compiled against php-src after this =
commit
> can no longer be loaded into earlier builds due to the missing =
__zend_malloc
> symbol.
>=20
> Most current extensions with PHP 7 compatibility aren't affected, but =
the one
> relatively common case where a persistent allocation occurs is when =
defining
> classes: INIT_CLASS_ENTRY() ultimately expands to
> INIT_OVERLOADED_CLASS_ENTRY_EX(), which calls zend_string_init() with =
the
> persistent flag enabled to create the class name string.
>=20
> It's awkward, since PHP 7.0 hasn't officially been released yet, but =
it sucks that
> some extensions won't be binary compatible between RC2 and RC3 (as =
things
> stand today). Options, as I see it:
>=20
> 1. Revert this commit.
> 2. Bump the extension API number.
> 3. Document that binary compatibility was broken in RC3, and that we =
don't
> guarantee binary compatibility before a stable release is made.
>=20
> I personally don't think option 3 is viable (yes, it's not a stable =
release, but it's
> still crappy =E2=80=94 avoiding this kind of thing is _why_ we have =
API versioning!).
> Dmitry, RMs: what are your thoughts?
>=20
While your observation is correct, I wouldn't see the matter as an =
alarming issue. We're oriented to have less bugs in every next RC, thus =
RC2 will have had its day soon anyway. So IMHO this change is not quite =
nice at this stage, but still acceptable.

Regards

Anatol=20