Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88197
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALLYd6Rd4FsC=sqYZuXzgQyjZqY7YcWKfLVK4M2zeFuQ7=WS3Q@mail.gmail.com>
References: <CALLYd6Rd4FsC=sqYZuXzgQyjZqY7YcWKfLVK4M2zeFuQ7=WS3Q@mail.gmail.com>
Date: Mon, 14 Sep 2015 15:38:35 -0600
Message-ID: <CAObuZdvBxP2DRvXp7VFfYZYvOY=vPubVHQ-v1__J8r+5RNAV+g@mail.gmail.com>
To: Daniel Persson <mailto.woden@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0438933547a835051fbbe351
Subject: Re: [PHP-DEV] Suggestion: Adding PUT, PATCH and DELETE
From: derokorian@gmail.com (Ryan Pallas)

--f46d0438933547a835051fbbe351
Content-Type: text/plain; charset=UTF-8

On Mon, Sep 14, 2015 at 3:22 PM, Daniel Persson <mailto.woden@gmail.com>
wrote:

> Hi.
>
> I've not been a member for too long so I might have missed if this have
> been discussed earlier.
>
> But I've created a small PR to the basic request handling to support PUT,
> PATCH and DELETE.
>
> https://github.com/php/php-src/pull/1519
>
> Summary:
>
> Added support for request methods with the smallest change possible.
> History:
>
> HTTP 1.0 had only support for GET, POST and HEAD.
> In June of 1999 HTTP 1.1 added the verbs PUT and DELETE and later in 2010
> RFC5789 (https://tools.ietf.org/html/rfc5789) added PATCH.
> Pull request explaination:
>
> In this pull request I try to add put, patch and delete with changing as
> few functions as possible. I simply handle the new verbs as POST. As
> defined in HTTP 1.1 they are similar in input data requirements and differ
> only in usage.
>

+1 from me, would love to see the verbs supported more fully. (though my
approval means quite literally nothing). How does this affect something
like the ini settings for variable order? IE. does GPC change from GET ->
POST -> COOKIE to GET -> PARSED_INPUT -> COOKIE? Since only a single verb
is available for any single request, this makes the most sense for me.


>
> More work I could do is add new globals for $_PUT, $_PATCH and $_DELETE but
> I think this might be more confusing. Or we could move from $_POST to a new
> global not tied to a verb. Example $_PARSED_INPUT


As for having a new $_PARSED_INPUT, I'm not sure I like this for 2 reasons
a) the name is 2 words, all other super globals are single words (unless
there's one I do not know of) and b) It feels like too long a name, sure in
an IDE it will auto-complete for us, but for quick edits in vim for
example, this name would suck. But my only problem with it is on a name
level, about about just $_INPUT or does this seem to conflict with
$_REQUEST which holds multiple super globals worth of data already.

--f46d0438933547a835051fbbe351--