Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88130
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.22 as permitted sender)
To: Kalle Sommer Nielsen <kalle@php.net>, Matteo Beccati <php@beccati.com>
References: <55EF58B4.4080005@gmx.de>
 <CAJW__o25PimFW3VtoCXhOWBcCT-bxnxHhTjKWWpjpjnfPBf_FA@mail.gmail.com>
Cc: Internals <internals@lists.php.net>
Message-ID: <55F0B62F.2010506@gmx.de>
Date: Thu, 10 Sep 2015 00:43:59 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CAJW__o25PimFW3VtoCXhOWBcCT-bxnxHhTjKWWpjpjnfPBf_FA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] DOMElement::nodeValue is not W3C conforming
From: cmbecker69@gmx.de (Christoph Becker)

Hi Kalle, hi Matteo,

Kalle Sommer Nielsen wrote:

> 2015-09-08 23:52 GMT+02:00 Christoph Becker <cmbecker69@gmx.de>:
>
>> In bug #70029 it has been reported that DOMElement::nodeValue currently
>> does not conform to the W3C specs.  Instead of NULL, it returns the
>> ::textContent.
>>
>> I had committed the patch for master only, to avoid the undesirable BC
>> break for PHP 5.6, but there have been concerns that the BC break might
>> even be to severe for PHP 7.0.
>>
>> Therefore I'm bringing this issue to the list.  Is it okay to fix the
>> behavior for PHP 7.0?  Shall we wait until 7.1?  Does that require an RFC?
> 
> Small self contained things like this should not in my book at least
> require an RFC, that is way overkill.

ACK

> For 7.0, it is just fine, although I'm a little concerned over some of
> the fixes like this after we have reached RC, and would prefer at
> least we go to the ML before committing or similar (I'm on the run a
> lot, so mails is the only ressource for me to keep myself up to date
> quickly).

Also considering Matteo's reply, it seems to be best to postpone this
fix to PHP 7.1.  Apparently, it would break a lot of stuff, we're
already in RC, and actually it works this way since PHP 5.0.0, so
there's no need to hurry. :)

> As for 5.6, that is up to Ferenc if he finds it suitable to include.
> But I do think that breaking BC for this, even though its a fix, is
> not a good idea in a patch release.

ACK

-- 
Christoph M. Becker