Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88051
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.220.51 cause and error)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (1.0)
In-Reply-To: <CAJW__o2eceAxEpxMye2n+kiq2_Qm5GMSzKmaW=ifHx=uw26Qzg@mail.gmail.com>
Date: Sat, 5 Sep 2015 02:47:24 +1200
Cc: Davey Shafik <davey@php.net>,
 "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <FAAF4521-60B6-4388-AC09-6EF59CD19E0C@daveyshafik.com>
References: <CANaX5ncSnnkYV0OQp3AD6voV-AuttkR4Sr=9rUPnHLnuZdDndg@mail.gmail.com> <CAJW__o2eceAxEpxMye2n+kiq2_Qm5GMSzKmaW=ifHx=uw26Qzg@mail.gmail.com>
To: Kalle Sommer Nielsen <kalle@php.net>
Subject: Re: [PHP-DEV] Add HTTP/2 Multiplexing-related constants to ext/curl
From: me@daveyshafik.com (Davey Shafik)


> On Sep 5, 2015, at 02:00, Kalle Sommer Nielsen <kalle@php.net> wrote:
>=20
> Hi Davey
>=20
> 2015-09-02 7:31 GMT+02:00 Davey Shafik <davey@php.net>:
>> Hi,
>>=20
>> I've been poking around at HTTP/2 a lot lately, and it seems that so long=

>> as you are using libcurl 7.43.0+ it's possible to do request multiplexing=
.
>>=20
>> This change simply introduces three constants, CURLPIPE_NOTHING (0),
>> CURLPIPE_HTTP1 (1), and CURLPIPE_MULTIPLEX (2) which represent possible
>> values passed into curl_multi_setopt() for the CURLMOPT_PIPELINING option=
.
>> Current behavior of passing in 0 and 1 map to the first two constants,
>> while the third allows for multiplexing.
>>=20
>> Now, of course, being constants, you can just pass in 0, 1, or 2, but thi=
s
>> brings the consistency and explicitness of exposing them as with all the
>> other curl constants.
>>=20
>> I'd love to see this make it into PHP 7.0 if it's not too late? It's
>> extremely trivial, but whatever =E2=80=94 not that fussed :)
>>=20
>> PR is here: https://github.com/php/php-src/pull/1497
>=20
> Me and Anatol have talked it over and we're fine with this coming into
> RC3 as it beats having hardcoded values in the code or ugly hacks for
> 7.0.0 only, so go ahead and commit the PR.
>=20
> Thanks for your work :)

Hey Kalle,

This is great... but I don't have karma to merge it I don't think? Be happy t=
o be wrong :)

- Davey=