Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88050
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.179 as permitted sender)
MIME-Version: 1.0
Sender: kalle.php@gmail.com
In-Reply-To: <CANaX5ncSnnkYV0OQp3AD6voV-AuttkR4Sr=9rUPnHLnuZdDndg@mail.gmail.com>
References: <CANaX5ncSnnkYV0OQp3AD6voV-AuttkR4Sr=9rUPnHLnuZdDndg@mail.gmail.com>
Date: Fri, 4 Sep 2015 16:00:16 +0200
Message-ID: <CAJW__o2eceAxEpxMye2n+kiq2_Qm5GMSzKmaW=ifHx=uw26Qzg@mail.gmail.com>
To: Davey Shafik <davey@php.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Add HTTP/2 Multiplexing-related constants to ext/curl
From: kalle@php.net (Kalle Sommer Nielsen)

Hi Davey

2015-09-02 7:31 GMT+02:00 Davey Shafik <davey@php.net>:
> Hi,
>
> I've been poking around at HTTP/2 a lot lately, and it seems that so long
> as you are using libcurl 7.43.0+ it's possible to do request multiplexing=
.
>
> This change simply introduces three constants, CURLPIPE_NOTHING (0),
> CURLPIPE_HTTP1 (1), and CURLPIPE_MULTIPLEX (2) which represent possible
> values passed into curl_multi_setopt() for the CURLMOPT_PIPELINING option=
.
> Current behavior of passing in 0 and 1 map to the first two constants,
> while the third allows for multiplexing.
>
> Now, of course, being constants, you can just pass in 0, 1, or 2, but thi=
s
> brings the consistency and explicitness of exposing them as with all the
> other curl constants.
>
> I'd love to see this make it into PHP 7.0 if it's not too late? It's
> extremely trivial, but whatever =E2=80=94 not that fussed :)
>
> PR is here: https://github.com/php/php-src/pull/1497

Me and Anatol have talked it over and we're fine with this coming into
RC3 as it beats having hardcoded values in the code or ugly hacks for
7.0.0 only, so go ahead and commit the PR.

Thanks for your work :)



--=20
regards,

Kalle Sommer Nielsen
kalle@php.net