Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88047
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAB6YZuwfGhh=EBJySNndtRjstpbvGxvHoWKV=5GUNrx8Prc1tA@mail.gmail.com>
References: <BLU436-SMTP13020F8CE8795C628BDC665E26B0@phx.gbl>
	<CAESVnVq9kBhK_uEH2-HvQN4Wv8DVSnwc9ukRjrQ0KNjUbaAD7g@mail.gmail.com>
	<55E77CA9.7050609@gmail.com>
	<CAB6YZux4uYG7u0XRc_56MWFo+8G_h_VZZbWhCDVqA7hdu5XSpg@mail.gmail.com>
	<55E81959.6040305@gmail.com>
	<CAB6YZuwimHWkh8ddvkagmXRQVCK-joUSmMYKKxxjx22BbktSRg@mail.gmail.com>
	<CAEU6NAdfF0w383CNF46B8-Ly2Me+nzwpDFUvjeR4ZHk3x1MoUQ@mail.gmail.com>
	<CAB6YZuwfGhh=EBJySNndtRjstpbvGxvHoWKV=5GUNrx8Prc1tA@mail.gmail.com>
Date: Fri, 4 Sep 2015 10:10:49 +0200
Message-ID: <CALLYd6TduOcvHW8Dr_0bg6eTLL6y-WTt2O6AstP3cXQxECi_uQ@mail.gmail.com>
To: =?UTF-8?Q?Pavel_Kou=C5=99il?= <pajousek@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c3421c07316d051ee7702b
Subject: Re: [PHP-DEV] [RFC] [Discussion] Short Closures
From: mailto.woden@gmail.com (Daniel Persson)

--001a11c3421c07316d051ee7702b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

> Depends how you define simplicity. Because $a ~> $b ~> $c ~> $d is
> IMHO more simple than ($a) ~> ((($b) ~> (($c) ~> $d($foo))) - which is
> a result of the combination of amendments #2 and #3. I honestly do not
> know if I wrote the parenthesis right now or not (probably not),
> because there's simply just too many of them.

Might be a good place to suggest refactoring?
Removing a semantics because when you try to write too dense code it's hard
to read.
The same goes with an one line if assignments.

$a =3D ( [some really big expression] ) ? $b : $c;

Could be really hard to read but then you look into refactoring that code.

Might be my inexperience with closures but when do you chain 3 of them?

Best regards
Daniel


On Fri, Sep 4, 2015 at 9:43 AM, Pavel Kou=C5=99il <pajousek@gmail.com> wrot=
e:

> On Fri, Sep 4, 2015 at 8:57 AM, Peter Lind <peter.e.lind@gmail.com> wrote=
:
> > On 4 September 2015 at 08:44, Pavel Kou=C5=99il <pajousek@gmail.com> wr=
ote:
> >
> > You're arguing that, subjectively, to you - parentheses make things
> harder
> > to read. For others they clarify things.
> > It should be obvious to everyone that this particular path of the
> discussion
> > has about as much merit as tabs vs spaces.
>
> Sure, it is subjective - but what isn't?
>
> > That being the case, I would argue for consistency and simplicity. If y=
ou
> > need parentheses for other variants of this, require parentheses all th=
e
> way
> > through. It will be simpler to learn and trip fewer people up.
>
> Depends how you define simplicity. Because $a ~> $b ~> $c ~> $d is
> IMHO more simple than ($a) ~> ((($b) ~> (($c) ~> $d($foo))) - which is
> a result of the combination of amendments #2 and #3. I honestly do not
> know if I wrote the parenthesis right now or not (probably not),
> because there's simply just too many of them.
>
> Sure, parenthesis can help people understand things, but I'd say that
> at the same time, too many of them can be a problem as well (as the
> fun name for LISP - "lost in stupid parenthesis" - suggests).
>
> > Just think, if whoever constructed the if conditional hadnt thought "he=
y,
> > let's be clever and save some keystrokes by making the curlies optional
> in
> > some cases" we wouldn't have the multitude of bugs and security holes w=
e
> > know to exist, we wouldn't have to warn the young'uns against improper
> use
> > of if, we wouldn't have to write codesniffer rules against single line
> ifs,
> > etc, etc.
> >
> > Any argument to the effect of "let's be clever" or "it'll save some
> > keystrokes" is void. Period.
>
> This is not about saving characters, it's about not overcomplicating
> things.
>
> >
> > Regards
> > Peter
> >
>
> Regards
> PK
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a11c3421c07316d051ee7702b--