Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88005
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.41 as permitted sender)
To: Dmitry Stogov <dmitry@zend.com>
References: <55E698CA.4040809@gmail.com>
 <CA+9eiLtuYDcme+OE3t+wncaoqnyfqB_2ug_qvZyyw=2cVyWB2g@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Message-ID: <55E6A81D.6050109@gmail.com>
Date: Wed, 2 Sep 2015 00:41:17 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <CA+9eiLtuYDcme+OE3t+wncaoqnyfqB_2ug_qvZyyw=2cVyWB2g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: object_properties_load() does not work for non-string keys -
 intentional?
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> I don't see the crash. Integer keys are supported in exactly the same
> way as it was in PHP-5.

I see the crash on this test:

https://github.com/smalyshev/php-src/blob/master/ext/spl/tests/bug70155.phpt

I'm not sure how integer keys are supported the same way if I see this
in the code:

https://github.com/php/php-src/blob/master/Zend/zend_API.c#L1248

	ZEND_HASH_FOREACH_STR_KEY_VAL(properties, key, prop) {
		property_info = zend_get_property_info(object->ce, key, 1);

The loop doesn't even consider the possibility of key being NULL (which
happens with integer key) and only considers string keys, and, if the
key is integer, zend_get_property_info gets null as key argument and
segfaults.

-- 
Stas Malyshev
smalyshev@gmail.com