Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:88002 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45301 invoked from network); 2 Sep 2015 06:36:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2015 06:36:10 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.42 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.42 mail-pa0-f42.google.com Received: from [209.85.220.42] ([209.85.220.42:36357] helo=mail-pa0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F6/26-23910-8D896E55 for ; Wed, 02 Sep 2015 02:36:09 -0400 Received: by pacwi10 with SMTP id wi10so754709pac.3 for ; Tue, 01 Sep 2015 23:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:from:subject:message-id:date:user-agent:mime-version :content-type:content-transfer-encoding; bh=GvtK35+Cz2MlbnVEjvMRycJXB2Drf6fXuZZ4bwMAK8o=; b=jqV7telN4Ia3D/iNrF5uljHfvMI/BXfYAF+cG7KN6HtS15FA8sAzIhBJKTzUGxPFYx PwJ2CO9zXT965pzdKNqEbnxIUf9AmpzMYZr0aEvMFm+QL+I5wxaFsJCxHqJAUmqq1wOD R/IMXH+c7F4ZHh34z6l0t4VskncGfP31d9athcvqS4kRcG5cp3Qj9vcDK6szCwjhUJ/C WW7/4nzLqYN+WwFFqnXDnLBgju45AA6JMUHLOFrS8cr6SGrdyY53AKVstRJbbrdn3xmF hfbJ2rBiZSwesIYQY4guvR5m+/OXuDAmQDsQraXPTxIAwPUHXVX4tR0NFZvpD4Rev1VL Mglg== X-Received: by 10.66.164.130 with SMTP id yq2mr54296300pab.67.1441175765994; Tue, 01 Sep 2015 23:36:05 -0700 (PDT) Received: from Stas-Air.local (108-66-6-48.lightspeed.sntcca.sbcglobal.net. [108.66.6.48]) by smtp.gmail.com with ESMTPSA id xd10sm138936pab.25.2015.09.01.23.36.04 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 Sep 2015 23:36:05 -0700 (PDT) To: PHP Internals , Dmitry Stogov Message-ID: <55E698CA.4040809@gmail.com> Date: Tue, 1 Sep 2015 23:35:54 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: object_properties_load() does not work for non-string keys - intentional? From: smalyshev@gmail.com (Stanislav Malyshev) Hi! Working on unserialize edge case patches backporting, I've discovered that object_properties_load() function crashes if the properties array contains non-string keys (which can happen on unserialize). Now, I can fix the crash, but I can fix it in two ways: 1. Ignore such keys (i.e. such properties will be banned, BC break against 5.x) 2. Treat such keys as in 5.x i.e. insert them in the hash. So, I wanted to know if dropping non-string keys there was intentional or not? -- Stas Malyshev smalyshev@gmail.com