Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87953
Return-Path: <anatol.php@belski.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 94752 invoked from network); 30 Aug 2015 20:13:28 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Aug 2015 20:13:28 -0000
Authentication-Results: pb1.pair.com header.from=anatol.php@belski.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=anatol.php@belski.net; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
X-PHP-List-Original-Sender: anatol.php@belski.net
X-Host-Fingerprint: 85.214.73.107 klapt.com  
Received: from [85.214.73.107] ([85.214.73.107:50133] helo=h1123647.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A3/72-17125-6E363E55 for <internals@lists.php.net>; Sun, 30 Aug 2015 16:13:26 -0400
Received: by h1123647.serverkompetenz.net (Postfix, from userid 1006)
	id 853B123D6299; Sun, 30 Aug 2015 22:13:22 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	h1123647.serverkompetenz.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=2.5 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED autolearn=unavailable version=3.3.2
Received: from w530phpdev (p579F38C9.dip0.t-ipconnect.de [87.159.56.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by h1123647.serverkompetenz.net (Postfix) with ESMTPSA id C6AF423D6003;
	Sun, 30 Aug 2015 22:13:20 +0200 (CEST)
To: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'Rasmus Lerdorf'" <rasmus@lerdorf.com>,
	"'Ilia Alshanetsky'" <iliaa@php.net>,
	"'Zeev Suraski'" <zeev@zend.com>,
	"'PHP Internals'" <internals@lists.php.net>
Cc: "'Anatol Belski'" <ab@php.net>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>,
	"'Xinchen Hui'" <xinchen.h@zend.com>
References: <CA+9eiLvMo3ZSamGWsszSPJRdP6fE0kuH3WXN8XO1JCXXEH382Q@mail.gmail.com>
In-Reply-To: <CA+9eiLvMo3ZSamGWsszSPJRdP6fE0kuH3WXN8XO1JCXXEH382Q@mail.gmail.com>
Date: Sun, 30 Aug 2015 22:13:17 +0200
Message-ID: <004001d0e360$516232e0$f42698a0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Microsoft Outlook 15.0
Thread-Index: AQKFiTSn7jVI3KOvbCNCeIde2s+ozJy7CM/w
Content-Language: en-us
Subject: RE: [PHP-DEV] Disable SAPI based HANDLE_BLOCK_INTERRUPTIONS()
From: anatol.php@belski.net ("Anatol Belski")

Hi Dmitry,

> -----Original Message-----
> From: Dmitry Stogov [mailto:dmitry@zend.com]
> Sent: Friday, August 28, 2015 3:24 PM
> To: Rasmus Lerdorf <rasmus@lerdorf.com>; Ilia Alshanetsky =
<iliaa@php.net>;
> Zeev Suraski <zeev@zend.com>; PHP Internals <internals@lists.php.net>
> Cc: Anatol Belski <ab@php.net>; Nikita Popov <nikita.ppv@gmail.com>; =
Xinchen
> Hui <xinchen.h@zend.com>
> Subject: [PHP-DEV] Disable SAPI based HANDLE_BLOCK_INTERRUPTIONS()
>=20
> Hi,
>=20
> I've disabled SAPI based signal protection.
> It was used only by Apache1 SAPI, but PHP7 doesn't support it anyway.
> So, we had to perform useless checks on each zend_hash_add().
>=20
> Please take a look, and tell me if you see possible problems.
>=20
> I think, it makes sense to completely remove corresponding  API in =
zend.h and
> SAPI.h.
>=20
It doesn't look like zend_utility_functions struct was ever used outside =
the core, so ABI compat is not really a concern. Given no SAPI would =
inject these hooks anymore (and that was actually Apache only that did =
it), IMHO it is fine to remove the corresponding parts.

Regards

Anatol