Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87930
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain craigfrancis.co.uk designates 209.85.212.172 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
In-Reply-To: <55DD4269.4090402@gmail.com>
Date: Wed, 26 Aug 2015 12:23:07 +0100
Cc: Scott Arciszewski <scott@paragonie.com>,
 PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <6348DFA7-04BD-41BB-A500-17A8A531B56C@craigfrancis.co.uk>
References: <CAKws9z27kVJ87Ur5Qo+ayYHPeeO=aYKpRHUV4TFBXX2iMcgO2A@mail.gmail.com> <55DD4269.4090402@gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Subject: Re: [PHP-DEV] PHP 7.1 - Address PHPSadness #28?
From: craig@craigfrancis.co.uk (Craig Francis)

On 26 Aug 2015, at 05:36, Stanislav Malyshev <smalyshev@gmail.com> =
wrote:
>=20
>> Would anyone be interested in adding another helper like
>> isset()/empty() simply called exists() which would return true if the
>> variable is defined in the current scope (i.e. without raising an
>> E_NOTICE)?
>=20
> Not sure what the use case would be for this. For most practical
> purposes, isset/empty look completely fine.




As a web (not core) developer I've been bitten by this a couple of =
times.

Both were fairly quick to identify/fix, but enough to be a little =
annoying.

If you want some example of where I got this wrong...



I have a config array for defining the websites CSP header, it starts =
something like:

    $csp_directives =3D array(
            'default-src'  =3D> array("'none'"),
            'form-action'  =3D> array("'self'"),
            'style-src'    =3D> array("'self'"),
            'img-src'      =3D> array("'self'"),
            'script-src'   =3D> array("'self'"),
        );

Depending on the website I may then add a key to define the =
'report-uri', or I may set it to NULL to say that I don't want one. If =
it remains unset (key does not exist), then the framework provides a =
default. At first I used an isset() check, forgetting that setting to =
NULL would not be seen as "set".



When creating a URL builder that allowed the query string to be passed =
in as an array. If it defaulted to the current URL (with its query =
string values), then the passed in array might tell it to explicitly =
remove certain values by setting them to NULL. When I first wrote this, =
I did an isset() check when adding the current URL's query string to the =
array of query string values (which take precedence).



Neither were major problems, just a slight annoyance (i.e. identified =
and fixed before I committed the code). But I'm normally using an =
isset() as the proposed exists() function would work.







On 26 Aug 2015, at 05:36, Stanislav Malyshev <smalyshev@gmail.com> =
wrote:

> Hi!
>=20
>> Would anyone be interested in adding another helper like
>> isset()/empty() simply called exists() which would return true if the
>> variable is defined in the current scope (i.e. without raising an
>> E_NOTICE)?
>=20
> Not sure what the use case would be for this. For most practical
> purposes, isset/empty look completely fine.
>=20
>> It should be a simple change to add this function but it's too late
>> for 7.0 so, if there is any interest, I would respectfully put it off
>> until 7.1.
>=20
> It is simple, but not everything that is simple should be done.
> Especially when we talking about adding core functions.
>=20
> --=20
> Stas Malyshev
> smalyshev@gmail.com
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20