Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87909
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Jakub Zelenka'" <bukka@php.net>
Cc: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'Rowan Collins'" <rowan.collins@gmail.com>,
	"'PHP Internals'" <internals@lists.php.net>
References: <02a601d0dbed$2c828df0$8587a9d0$@belski.net>	<CAL+t6cHdJNNySG0x76a1k_903XrFmfcCDHHH8LbmiTRNoQ3c4Q@mail.gmail.com>	<02ae01d0dbf5$01c17330$05445990$@belski.net>	<02b001d0dbf5$607ab7b0$21702710$@belski.net>	<CAL+t6cEsfH6m6HPbr9KoenSA3N35spucpoE=norTWS9dKZJJNA@mail.gmail.com>	<02ba01d0dbfb$3de2c390$b9a84ab0$@belski.net>	<CAL+t6cFXSZ5WYCZ00=uBkiZqVNWcHh9SBu+Kgtnr-v0iP8sRyA@mail.gmail.com>	<55DA4924.2060401@gmail.com>	<00c101d0de77$4a809680$df81c380$@belski.net>	<CA+9eiLvRDAvg48RR1UMm=eK9pU3Rw0xtWZJhNY665tKj6+d8TA@mail.gmail.com>	<01bd01d0df2a$f2484f30$d6d8ed90$@belski.net> <CAEKnhAEKy1McSh27bV-BmQQU=8-vsPQbYQeDFtUfCyK0HKpHcQ@mail.gmail.com>
In-Reply-To: <CAEKnhAEKy1McSh27bV-BmQQU=8-vsPQbYQeDFtUfCyK0HKpHcQ@mail.gmail.com>
Date: Tue, 25 Aug 2015 15:25:00 +0200
Message-ID: <01e301d0df39$7349a300$59dce900$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQK9NdJN9egRUY1Umglkf8yuRLR3fgF0Y2w7Afrl8XkB4m4i6wDvLFLZAq3KEX4CFSYQhQFhBjf9Ai+bDhcB4PvUaQH8FipzAZG9Rt+bo+g9MA==
Content-Language: en-us
Subject: RE: [PHP-DEV] Overflow checks and integral vars comparison
From: anatol.php@belski.net ("Anatol Belski")

Hi Jakub,

> -----Original Message-----
> From: jakub.php@gmail.com [mailto:jakub.php@gmail.com] On Behalf Of =
Jakub
> Zelenka
> Sent: Tuesday, August 25, 2015 2:46 PM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: Dmitry Stogov <dmitry@zend.com>; Rowan Collins
> <rowan.collins@gmail.com>; PHP Internals <internals@lists.php.net>
> Subject: Re: [PHP-DEV] Overflow checks and integral vars comparison
>=20
> Hi Anatol,
>=20
> On Tue, Aug 25, 2015 at 12:41 PM, Anatol Belski =
<anatol.php@belski.net>
> wrote:
>=20
> > Hi Dmitry,
> >
> > > -----Original Message-----
> > > From: Dmitry Stogov [mailto:dmitry@zend.com]
> > > Sent: Tuesday, August 25, 2015 9:29 AM
> > > To: Anatol Belski <anatol.php@belski.net>
> > > Cc: Rowan Collins <rowan.collins@gmail.com>; PHP Internals
> > > <internals@lists.php.net>
> > > Subject: Re: [PHP-DEV] Overflow checks and integral vars =
comparison
> > >
> > > Hi Anatol,
> > >
> > > I don't see any problem adding ZEND_LONG_INT_OVF and similar =
macros
> > > into 7.0.
> > >
> > Thanks for taking a look. I was doing a quick RFC draft yesterday =
also
> > including a ZPP suggestion from Jakub. But given there's some demand
> > on such checks still, probably better I withdraw the RFC and work
> > towards macros for the range checks and integrating them at the =
appropriate
> places.
> > Pure internal stuff anyway.
> >
> >
> I think it makes sense to merge all macros without RFC to master for =
7.0 and
> keep RFC just for ZPP changes as there might be some discussion about =
the
> names (e.g. "r" is already used for resources ;) ). Or maybe just =
check if everyone
> is ok with names (ZPP flags) and then integrate it as well. In any =
case, it would be
> nice to have this in ZPP at some point.
>=20
Yep, was just a quick writing yesterday, overseen the 'r'. Actually pity =
as it could be like 'q', 'r,', 's' ... easy to memorize :)

With ZPP there could be also a little performance concern, as it would =
add four cases to parse to ZPP yet. So probably also depends on which =
scale it is needed. And another point is that an implementation with the =
fast ZPP were needed as well. So turns out as a bit more than it looked =
at the start, but would be IMHO useful from the functional sight.

I'd be working of the macros next days, to cover as much as possible =
then.

Regards

Anatol