Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87848
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain lerdorf.com designates 209.85.192.45 as permitted sender)
Message-ID: <55D79F7B.3030302@lerdorf.com>
Date: Fri, 21 Aug 2015 15:00:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Anthony Ferrara <ircmaxell@gmail.com>, 
 Scott Arciszewski <scott@paragonie.com>
CC: Pierre Joye <pierre.php@gmail.com>, Trevor Suarez <rican7@gmail.com>, 
 Niklas Keller <me@kelunik.com>,
 PHP Internals <internals@lists.php.net>
References: <CAKws9z25cW7MTFeSanYVJK64Lb1uJYm5JJ82h7DDG1Td+j3EuA@mail.gmail.com>	<CAPwsocHaTtGjL8CAdzAvbSN2wZSGZ50SRC6MBNKO0WtXzAZu3g@mail.gmail.com>	<CANUQDCgiJVackjoxDaPmZWn_wCcDAZ=BwvhDzdaXsLhSPFVeRA@mail.gmail.com>	<99CE9AAF-E6E9-4D37-B462-E4A63139EAFB@icicle.io>	<CAKws9z0Q2WMxAGVZAgz=noJbViqmEJb43SWo_fB6MTum3ptFDA@mail.gmail.com>	<CAKws9z2pKRHR0kaTgw=UhLLeUDPS8MpY70PCMsSwsFxJnPbAZw@mail.gmail.com>	<CANUQDCj-yBLNWGP60YBfjRjtAUMC2SpbQJaVjy3qjhhz0gFAEw@mail.gmail.com>	<CAHXmDMCW0hP+-hB9Geo-niu+LkvTPKXKrbKkaki=nMuQSRMCuw@mail.gmail.com>	<CAKws9z2w31Tjya9ctsfQYk416Yb_SRRGRNyCCSsJLRyZ_aHpbQ@mail.gmail.com>	<CAEZPtU6yRQrGmG-Pw+z28QD+8vKGhvSSQ9vr4mrqE_qCrKubhA@mail.gmail.com>	<CAKws9z2V3rYFuPdxLcTcV_9sLEySydcapMOtq3Xu21hmGH-44Q@mail.gmail.com> <CAAyV7nHpV_KujJbS8E+jU3aOTGL9pDDfcwFe=0t-_3A2k+ONnA@mail.gmail.com>
In-Reply-To: <CAAyV7nHpV_KujJbS8E+jU3aOTGL9pDDfcwFe=0t-_3A2k+ONnA@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="6DwBtjBlsNiebGq7sHxnccfHCkEQO0svQ"
Subject: Re: [PHP-DEV] Recap - Core functions throwing exceptions in PHP7
From: rasmus@lerdorf.com (Rasmus Lerdorf)

--6DwBtjBlsNiebGq7sHxnccfHCkEQO0svQ
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 08/21/2015 06:36 AM, Anthony Ferrara wrote:
> My proposal/stance:
>=20
> Let's make random_* throw an Exception if it cannot connect to a
> random source. And let's have it throw an TypeError if ZPP fails, or
> Error if min >=3D max.
>=20
> The first two are consistent with existing exceptions.

I don't think anyone would argue those two. It makes sense.

> The third (Error if min>max) is where the contention lies. I'm
> suggesting Error as it's consistent with parameter errors in the sense
> that the type may be correct, but the value isn't (hence it's the same
> kind of error as a parameter error, just a different
> sub-classification.
>=20
> MHO is this is too important of a distinction to simply gloss over.
> Having it return false (or null) will be a problem, as nobody will
> perform the error checks. And returning $x where `$x =3D=3D 0` in a
> security context could be incredibly bad. As such, I think the
> security implications here outweigh nearly all of the other concerns
> about consistency and convention.
>=20
> That's my opinion. I'll be happy to make the changes if a RM gives me
> the green light to do so.

An error on this makes sense to me too and it doesn't seem like much of
an issue to make this change now. But yes, it is the RM's final call.

-Rasmus



--6DwBtjBlsNiebGq7sHxnccfHCkEQO0svQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlXXn3sACgkQlxayKTuqOuCVzwCfaFrofn3I98HV8uTeQW6hnsFU
zTAAoIm7r3BPNqoyIwZ87p5k8znmdcHD
=9cQ4
-----END PGP SIGNATURE-----

--6DwBtjBlsNiebGq7sHxnccfHCkEQO0svQ--