Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:87822 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22738 invoked from network); 20 Aug 2015 17:08:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Aug 2015 17:08:06 -0000 Authentication-Results: pb1.pair.com smtp.mail=kalle.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=kalle.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.169 as permitted sender) X-PHP-List-Original-Sender: kalle.php@gmail.com X-Host-Fingerprint: 209.85.212.169 mail-wi0-f169.google.com Received: from [209.85.212.169] ([209.85.212.169:35286] helo=mail-wi0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9F/27-00671-57906D55 for ; Thu, 20 Aug 2015 13:08:06 -0400 Received: by wicne3 with SMTP id ne3so151542854wic.0 for ; Thu, 20 Aug 2015 10:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=AnEcpU/P+4kNgdK2Gp3gwLr3fTE+tNvDAuj/JslAcjg=; b=TdWHOH9TxDFASzy6eFuoNMPHBzmUmti4BibqexD0fTV/jV0MF0jOKj3ROCarpZGwI8 DrA/PXzwwJ6skNYQB0+5gs5jAo4tOy9zLo7kP9/5XYT2F6zjHFFWZ/xOOAZqtuA8TgLH TjaB+Q93nyz0E95M/VgNbZ3d3EXA2i65vHW0PwW7G2yKJJL64C3vQM59O3e6HWRpHiT/ NtW4gc7LVVN16DUdppLi9NvUXfYvJfDbEzxv3Xr5MGT8dG9OD2itaPCP3leRef3pB9Wp 0R+vLlKgBVnTjjub09dEdU6kQPJ0g3P/BrQ37LS4Zr0RJKFP6AYU10xR9XWr/I4pDxP3 Fn7g== MIME-Version: 1.0 X-Received: by 10.194.58.199 with SMTP id t7mr7874181wjq.45.1440090483167; Thu, 20 Aug 2015 10:08:03 -0700 (PDT) Sender: kalle.php@gmail.com Received: by 10.28.217.19 with HTTP; Thu, 20 Aug 2015 10:08:03 -0700 (PDT) Received: by 10.28.217.19 with HTTP; Thu, 20 Aug 2015 10:08:03 -0700 (PDT) In-Reply-To: References: <55D4E2B1.1040309@gmail.com> Date: Thu, 20 Aug 2015 19:08:03 +0200 X-Google-Sender-Auth: PaSVDMBZdug-stCoKUgcXMz65dA Message-ID: To: Sara Golemon Cc: Internals , Stas Malyshev , Anatoliy Belsky Content-Type: multipart/alternative; boundary=047d7bacc664b19698051dc131bb Subject: Re: [PHP-DEV] C++ Extensions From: kalle@php.net (Kalle Sommer Nielsen) --047d7bacc664b19698051dc131bb Content-Type: text/plain; charset=UTF-8 (sorry for top posting) Hi Sara, I think such will be just fine for RC2, unless Anatol got any object, go ahead. -K On Aug 20, 2015 6:49 PM, "Sara Golemon" wrote: > On Wed, Aug 19, 2015 at 1:10 PM, Stanislav Malyshev > wrote: > >> A) Adding those defines prior to including stdint.h > >> B) Expecting C++ ext devs to define those before including php.h > >> C) Modifying zend_long.h to use things like > >> std::numeric_limits() when __cplusplus is defined > >> > >> A may (potentially) have unexpected side-effects > >> B has precedent (see ext/intl/config.m4) > >> C makes the ifdef block that's already there notably more complex > > > > I'd rather have everything solved by php.h than having magic > > incantations that one has to do prior to it. I would prefer A unless > > there's really something wrong with it that. Given that these macros are > > on their way out anyway: > > https://sourceware.org/bugzilla/show_bug.cgi?id=15366 > > I'm not sure it's that dangerous to define them in the meantime. > > > I agree! :) Though I didn't realize they were deprecated anyway. > > Second question, is it too late to put it in 7.0.0? > Happy enough to put it behind #ifdef __cplusplus to limit the exposed > surface area. > > -Sara > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --047d7bacc664b19698051dc131bb--