Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87820
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.217.169 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <55D4E2B1.1040309@gmail.com>
References: <CAESVnVqPgb+WJsv6bS9d1gek-7cD0Td3rJnmPxD7c4DSxp9Bvw@mail.gmail.com>
	<55D4E2B1.1040309@gmail.com>
Date: Thu, 20 Aug 2015 09:49:16 -0700
Message-ID: <CAESVnVquDd25Lq117+VUHsFJOjiN3OoDb6-LaEwA2erKOXhRGA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] C++ Extensions
From: pollita@php.net (Sara Golemon)

On Wed, Aug 19, 2015 at 1:10 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
>> A) Adding those defines prior to including stdint.h
>> B) Expecting C++ ext devs to define those before including php.h
>> C) Modifying zend_long.h to use things like
>> std::numeric_limits<int64_t>() when __cplusplus is defined
>>
>> A may (potentially) have unexpected side-effects
>> B has precedent (see ext/intl/config.m4)
>> C makes the ifdef block that's already there notably more complex
>
> I'd rather have everything solved by php.h than having magic
> incantations that one has to do prior to it. I would prefer A unless
> there's really something wrong with it that. Given that these macros are
> on their way out anyway:
> https://sourceware.org/bugzilla/show_bug.cgi?id=15366
> I'm not sure it's that dangerous to define them in the meantime.
>
I agree! :)  Though I didn't realize they were deprecated anyway.

Second question, is it too late to put it in 7.0.0?
Happy enough to put it behind #ifdef __cplusplus to limit the exposed
surface area.

-Sara