Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:87815 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92705 invoked from network); 19 Aug 2015 20:10:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Aug 2015 20:10:31 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.43 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.43 mail-pa0-f43.google.com Received: from [209.85.220.43] ([209.85.220.43:34645] helo=mail-pa0-f43.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/A0-20884-5B2E4D55 for ; Wed, 19 Aug 2015 16:10:29 -0400 Received: by paccq16 with SMTP id cq16so10118843pac.1 for ; Wed, 19 Aug 2015 13:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=Ne3p5mTM5sbMA7n3yz23qgpoKvi6YPfC99zwsd5286o=; b=D+mImQ14nnxm2bQ+xe48BDwzfBQJmSEuVjBey5m8sNFuRBwpN0wgIIj+8lY9neLfNO O3Z0Jj2Gt50UjZPYVpyC1tPeiriiz3iiTJ8QGCzv5YlT/1JnuxFsQuekZK7WT0+pPNYi b+6+MjOI2wnfIb4O50sS8yoWQszYyS9Xpt5sPOULGSMED4kbdU0TWe8Qntidn0c3Yw0Q HEUg1rKn2CKe+qVn4OnhK91Z13/WcNbF9wF7WjjBd99lOX30kWk58y6NM7AdleWTt17d V2Zbk71ibNfkwj5oIKIBEhwzv5bwzRnhHgTCytbU2IWOPGresbBru/mkpBk2sI9foynB aWOw== X-Received: by 10.68.193.169 with SMTP id hp9mr28806571pbc.39.1440015026102; Wed, 19 Aug 2015 13:10:26 -0700 (PDT) Received: from Stas-Air.local ([156.39.191.244]) by smtp.gmail.com with ESMTPSA id d4sm1780189pdc.93.2015.08.19.13.10.25 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 19 Aug 2015 13:10:25 -0700 (PDT) To: Sara Golemon , PHP internals References: X-Enigmail-Draft-Status: N1110 Message-ID: <55D4E2B1.1040309@gmail.com> Date: Wed, 19 Aug 2015 13:10:25 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] C++ Extensions From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > A) Adding those defines prior to including stdint.h > B) Expecting C++ ext devs to define those before including php.h > C) Modifying zend_long.h to use things like > std::numeric_limits() when __cplusplus is defined > > A may (potentially) have unexpected side-effects > B has precedent (see ext/intl/config.m4) > C makes the ifdef block that's already there notably more complex I'd rather have everything solved by php.h than having magic incantations that one has to do prior to it. I would prefer A unless there's really something wrong with it that. Given that these macros are on their way out anyway: https://sourceware.org/bugzilla/show_bug.cgi?id=15366 I'm not sure it's that dangerous to define them in the meantime. -- Stas Malyshev smalyshev@gmail.com