Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87803
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain telia.com from 81.236.60.154 cause and error)
To: Ryan Pallas <derokorian@gmail.com>
References: <20150817123142.13418f26@csystems>
 <CANUQDCiCdzvyn2m4VCF8cL85H-VWPYMjOYBEHh=fwqLaPj4+zw@mail.gmail.com>
 <20150817131900.66906015@csystems>
 <alpine.DEB.2.20.1508171458420.3273@whisky.home.derickrethans.nl>
 <55D1EE8E.9030603@php.net>
 <CAPg3XxL7zAA-6Q3Eo--DqYZJ9DH+d--punuYj_ihR9OmR_L1pg@mail.gmail.com>
 <55D45278.5050005@telia.com>
 <CANUQDCjHEi=iLYL8mK=9xEy9C8MZ1Ciix9MGU0e8qM9x9qVTLw@mail.gmail.com>
 <55D479F1.5000408@telia.com>
 <CAObuZdswW_LJgA6L2hX5XNWJvGRExfrg9MYCo2PCeRQqy_jGcg@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <55D490AB.7030507@telia.com>
Date: Wed, 19 Aug 2015 16:20:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CAObuZdswW_LJgA6L2hX5XNWJvGRExfrg9MYCo2PCeRQqy_jGcg@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------080402010002060407080102"
Subject: Re: [PHP-DEV] set_exception_handler catches all Throwables
From: bjorn.x.larsson@telia.com (=?UTF-8?Q?Bj=c3=b6rn_Larsson?=)

--------------080402010002060407080102
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Den 2015-08-19 kl. 15:55, skrev Ryan Pallas:
>
>
> On Aug 19, 2015 6:44 AM, "Björn Larsson" <bjorn.x.larsson@telia.com 
> <mailto:bjorn.x.larsson@telia.com>> wrote:
> >
> > Plan to migrate to PHP 7 later, like the new Exception/Error way
> > of working very much. Point is that current set_exception_handler
> > only address exceptions, not errors. You are right that on that the
> > surface it's the same callback, but could eg be logging in different
> > ways and to different recipients. Will look into it more later.
> >
> > Regards, //Björn
> >
> >
> > Den 2015-08-19 kl. 13:30, skrev Niklas Keller:
> >>
> >> What do you guys do in the set_exception_handler callback? Wouldn't 
> most code just use the same callback and just log the error / exception?
> >>
> >> Regards, Niklas
> >>
> >> 2015-08-19 11:55 GMT+02:00 Björn Larsson <bjorn.x.larsson@telia.com 
> <mailto:bjorn.x.larsson@telia.com> <mailto:bjorn.x.larsson@telia.com 
> <mailto:bjorn.x.larsson@telia.com>>>:
> >>
> >>
> >>     Den 2015-08-19 kl. 10:52, skrev Peter Cowburn:
> >>
> >>         On 17 August 2015 at 15:24, Sebastian Bergmann
> >>         <sebastian@php.net <mailto:sebastian@php.net>> wrote:
> >>
> >>             Am 17.08.2015 um 16:00 schrieb Derick Rethans:
> >>
> >>                 Actually, I don't call this intended. This is just as
> >>                 much as a BC break
> >>                 as the original implementation where Errors where also
> >>                 Exceptions. IMO,
> >>                 set_exception_handler() should be changed - with my
> >>                 preference it not
> >>                 capturing Error, and instead have an additional
> >>                 set_throwable_handler().
> >>
> >>               +1
> >>
> I agree with this completely. I think the point here is that 
> catch(Exception $e) remains unchanged while setting a handler actually 
> catches more things now. Tbh I feel like this is an oversight in 
> implementing the Error/Throwable rfc and should be addressed now, 
> otherwise it can't be changed until 8 if I understand correctly.
>
This is also a view that I share, feels more consistent that the handler
mimics v5 and catch(Exception $e) behaviour. Hope there can be a
decision / consensus on this topic.

Regards //Björn


--------------080402010002060407080102--