Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87796
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain telia.com from 81.236.60.154 cause and error)
To: Niklas Keller <me@kelunik.com>
References: <20150817123142.13418f26@csystems>
 <CANUQDCiCdzvyn2m4VCF8cL85H-VWPYMjOYBEHh=fwqLaPj4+zw@mail.gmail.com>
 <20150817131900.66906015@csystems>
 <alpine.DEB.2.20.1508171458420.3273@whisky.home.derickrethans.nl>
 <55D1EE8E.9030603@php.net>
 <CAPg3XxL7zAA-6Q3Eo--DqYZJ9DH+d--punuYj_ihR9OmR_L1pg@mail.gmail.com>
 <55D45278.5050005@telia.com>
 <CANUQDCjHEi=iLYL8mK=9xEy9C8MZ1Ciix9MGU0e8qM9x9qVTLw@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Message-ID: <55D479F1.5000408@telia.com>
Date: Wed, 19 Aug 2015 14:43:29 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CANUQDCjHEi=iLYL8mK=9xEy9C8MZ1Ciix9MGU0e8qM9x9qVTLw@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------020608070708050309010408"
Subject: Re: [PHP-DEV] set_exception_handler catches all Throwables
From: bjorn.x.larsson@telia.com (=?UTF-8?Q?Bj=c3=b6rn_Larsson?=)

--------------020608070708050309010408
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Plan to migrate to PHP 7 later, like the new Exception/Error way
of working very much. Point is that current set_exception_handler
only address exceptions, not errors. You are right that on that the
surface it's the same callback, but could eg be logging in different
ways and to different recipients. Will look into it more later.

Regards, //Björn

Den 2015-08-19 kl. 13:30, skrev Niklas Keller:
> What do you guys do in the set_exception_handler callback? Wouldn't 
> most code just use the same callback and just log the error / exception?
>
> Regards, Niklas
>
> 2015-08-19 11:55 GMT+02:00 Björn Larsson <bjorn.x.larsson@telia.com 
> <mailto:bjorn.x.larsson@telia.com>>:
>
>     Den 2015-08-19 kl. 10:52, skrev Peter Cowburn:
>
>         On 17 August 2015 at 15:24, Sebastian Bergmann
>         <sebastian@php.net> wrote:
>
>             Am 17.08.2015 um 16:00 schrieb Derick Rethans:
>
>                 Actually, I don't call this intended. This is just as
>                 much as a BC break
>                 as the original implementation where Errors where also
>                 Exceptions. IMO,
>                 set_exception_handler() should be changed - with my
>                 preference it not
>                 capturing Error, and instead have an additional
>                 set_throwable_handler().
>
>               +1
>
>         What's the plan for set_exception_handler() regarding
>         Throwables? Seeing as
>         we're now in the RC release phase I think this bone of
>         contention should be
>         resolved one way or another as soon as we can.
>
>     Yes, a "global" function that behaves differently between PHP 5 & 7 is
>     not optimal in my view. I'm also wondering how to make one handler
>     managing two different type of situations. @ircmaxwell described it in
>     *Core functions throwing exceptions in PHP7*:
>     "Errors signify programmer error, where Exceptions signify
>     unknown or runtime errors. Meaning that an Error should always be a
>     problem with your code, but an Exception could be a systems problem, a
>     user problem or a problem in your code."
>
>     /Cheers //Björn Larsson/
>
>     PS A bit new to this list but hope to have contributed a little :)
>
>


--------------020608070708050309010408--