Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87712
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 68.114.190.26 cause and error)
Message-ID: <8BE12FDCDC5C457282790368866BD61E@pc1>
To: <internals@lists.php.net>
Cc: "Dmitry Stogov" <dmitry@zend.com>
References: <B798F4D2069B4309AD72F91395561F38@pc1>
Date: Tue, 11 Aug 2015 13:00:05 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Parameter parsing for zval type?
From: php_lists@realplain.com ("Matt Wilmas")

Hi again,

----- Original Message -----
From: "Matt Wilmas"
Sent: Tuesday, August 11, 2015

> Hi Dmitry, all,
>
> Help me understand this. :-)  It's been more puzzling to me recently since 
> just coming to the part of optimizing traditional ZPP (sharing part with 
> FAST_ZPP...).
>
> With the FAST_ZPP inline macros, why is there a Z_PARAM_ZVAL and 
> Z_PARAM_ZVAL_DEREF?  It seems the zpp 'z' specifier is always like 
> ZVAL_DEREF, right?  So Z_PARAM_ZVAL has no equivalent in traditional zpp. 
> At the very least, this would seem to suggest a difference in 
> behavior/functionality.  But I haven't found any (or bug reports, if tests 
> didn't cover something).

Oops!  No, plain zpp 'z' does not have ZVAL_DEREF() applied, of course.  But 
it's also using zend_parse_arg_zval_DEREF(), which is wrong... (in the case 
of "z!" with reference to IS_NULL?).

> At first I assumed Z_PARAM_ZVAL would keep IS_REFERENCE types, since it 
> doesn't do ZVAL_DEREF(), but this obviously isn't happening with 
> references. (It seems they're getting DEREF()'d in VM when sending params, 
> I guess...?)

Still stands though that IS_REFERENCE doesn't seem to get through anyway 
(and would break functions).  Is any ZVAL_DEREF() *not* necessary?


- Matt