Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87604
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAKws9z02EYmBr0nbe7vShsg3NQYTuOg4+1jv50dRfoFPriwSvw@mail.gmail.com>
References: <CAKws9z1fatmSR2YLaeBn0zVv-s3iwCj7OUKjW949QC0L_VndpA@mail.gmail.com>
	<9996b5784a1bfbca80b07de01f1a7a94@k-piste.dy.fi>
	<CAEU6NAcHeeehpDgxEGMTyLRCNPbEvcgrJsDqs1uxGvTzBOKBDQ@mail.gmail.com>
	<CAKws9z14mg10UunmDe7yG6=ibXsKyK2wN6f+N4FG-9JUPHnp6w@mail.gmail.com>
	<CAEU6NAfx6ALo7ZAjkLOZEmPqFyyG5Re_71mQsViNxeDeKR13Pg@mail.gmail.com>
	<CAKws9z02EYmBr0nbe7vShsg3NQYTuOg4+1jv50dRfoFPriwSvw@mail.gmail.com>
Date: Tue, 4 Aug 2015 08:25:20 -0400
Message-ID: <CAGBOYXaxAUEmF5SdZLmAW2aL6RK5XO6rwZfcuMeNibYXySvDmg@mail.gmail.com>
To: Scott Arciszewski <scott@paragonie.com>
Cc: Peter Lind <peter.e.lind@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b3a89363026a0051c7b61e1
Subject: Re: [PHP-DEV] PHP 7.1 Cryptography Projects
From: jholmer.in@gmail.com (Joshua Holmer)

--047d7b3a89363026a0051c7b61e1
Content-Type: text/plain; charset=UTF-8

>
> >> Hi Peter,
> >>
> >> It's not really a "made-up string format", in the sense that it has a
> >> precedent (PDO).
> >>
> >
> > True, and that format sucks royally. It trips people up.
> >
> > Combining several arguments into one string is bad design. If it was good
> > design, you'd see userland code using it all over the place.
> >
>

I will fully agree that PDO's constructor format is terrible. Not only does
it lead to confusion but it thwarts any IDE's attempt to help the dev fill
the constructor arguments. I'm in favor of a format more like `new
\Namespace\Class(null, 'AES-256', 'GCM');`

As far as the rest of the discussion goes, I am +1.

--047d7b3a89363026a0051c7b61e1--