Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87499
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain malkusch.de designates 31.47.225.241 as permitted sender)
Message-ID: <55BDF0DD.10709@malkusch.de>
Date: Sun, 02 Aug 2015 12:28:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Stephen Coakley <me@stephencoakley.com>, internals@lists.php.net
References: <E6.64.22108.E69F7B55@pb1.pair.com> <55BBD019.5030106@stephencoakley.com> <55BC201D.6010600@malkusch.de> <55BC9361.1080804@malkusch.de> <55BCA7EE.4030301@gmx.de> <55BCDB57.5060609@malkusch.de> <6F.20.56402.69CADB55@pb1.pair.com> <55BDD9E0.6090801@malkusch.de> <55BDDEEE.9000407@malkusch.de>
In-Reply-To: <55BDDEEE.9000407@malkusch.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: Throwable::addSuppressed()
From: markus@malkusch.de (Markus Malkusch)

Markus Malkusch:

> try {
>     throw new Exception("Exception 1");
> 
> } finally {
>     try {
> 
>     } finally {
>         throw new Exception("Exception 3");
>     }
> }
> 
> In this case the only place for the suppressed exception 1 can be
> exception 3. For consistency and simplicity I'd therefore suggest that a
> Throwable has a list of supressed exceptions and a suppressed exception
> is always added to the resulting exception of a finally block.

Actually I my self was not really certain why adding it to the resulting
exception is better than setting it to the first exception. So I'd like
to present a further scenario which hopefully helps to decide for the
better definition:

try {
    throw new Exception("Exception 1");

} finally {
    try {
        throw new Exception("Exception 2");

    } catch (Exception $e) {
         // Don't throw anything cause this is expected.

    } finally {
        throw new Exception("Exception 3");
    }
}

So in this scenario again exception 3 will be the resulting exception.
exception 2 is expected and caught. Regarding exception 1 consider these
two definitions:

1) The supressed exception will be attached to the first raised
exception. This would be exception 2 in this case. Exception 2 is
handled and the information about exception 1 is lost.

2) The supressed exception is added to the resulting exception of the
finally block. This would be exception 3 in this case. The information
is still present.

So therefore I would vote for definition two. But I am also curious on
other opinions.

Markus Malkusch