Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87492
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.49 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>,
 Nicolas Grekas <nicolas.grekas+php@gmail.com>
References: <CAMUwpuTRzQHqznqKF-q=1Wy-Xnob9mra748E26YiZMKUa7-4DQ@mail.gmail.com>
 <CAOWwgp=E_ap59FQ4SJYEMHa6oNbP4s1OhOvMRQnJwYoWhTYk1w@mail.gmail.com>
 <CAF+90c8=hO5EuXWB7dQ3XbN7GqUxZ=ro6Vvwz+2PFa+nq=DkOg@mail.gmail.com>
Cc: Julien Pauli <jpauli@php.net>, PHP Internals <internals@lists.php.net>
Message-ID: <55BDC196.1030306@gmail.com>
Date: Sun, 2 Aug 2015 00:07:02 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c8=hO5EuXWB7dQ3XbN7GqUxZ=ro6Vvwz+2PFa+nq=DkOg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Exposing object handles to userland
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> I'd prefer to add a separate function spl_object_id, which directly returns
> the handle. This should supersede spl_object_hash in the long run.

Since in PHP 7 there's no longer a possibility of having different
object stores, as far as I can see, spl_object_id can identify an object
(it wasn't possible before 7).

However, committing to having specific object ID (e.g. as integer) as
part of public API is pretty big commitment which I personally think
creates unnecessary coupling between PHP internals and user code and is
a bad design decision which may bite us later.

> spl_object_hash does a bunch of pointless things that serve no purpose
> other than making the function slower and making the result more bulky.

Before PHP 7, it created proper object identification, as objects could
be stored in different stores. As PHP 7 removed that possibility, indeed
adding Z_OBJ_HT_P is no longer serving any purpose. Performance though
has very little to do with it - it's just two XORs and one printf.

-- 
Stas Malyshev
smalyshev@gmail.com