Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87428
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.162 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXaRGcC60ifxykb=Qox5VJVEPJ4X4BFTjXirk=A_Mgi_tQ@mail.gmail.com>
References: <CALYT1Yo-ae+cemXaaXs5Jv5t2DSzdxdYuxuhEGbXyoo_863+bw@mail.gmail.com>
	<836BA21C-AE99-4E7B-AB06-EBC30E41BA0E@icicle.io>
	<CAKws9z2PQWT7rSsM5R9TD-O69Ovy7-eifAuF-S0BQhBh3z4h1w@mail.gmail.com>
	<0AD335F5-35F3-4D98-8F82-800A1EDF8FD8@icicle.io>
	<05f101d0c838$fcdab5e0$f69021a0$@belski.net>
	<CAKws9z0yjxWisObfQ323rk3fA78yqJtRG=6zYDvjuPHEKH4=ag@mail.gmail.com>
	<55B63FDF.6050100@gmail.com>
	<CAKws9z1nXmci53v+3xOnROo-t45hwc9QTzJgdACBgDoi1O7DnQ@mail.gmail.com>
	<55B66494.1020106@gmail.com>
	<CAKws9z3=xJi3MwEN6Qi7Xxaphr3KLXZcAwmiN-jq924iKUpN3w@mail.gmail.com>
	<55B6707A.3040405@gmail.com>
	<CAAyV7nFxJB79VtypdRUpc=diZL1HcQ_ACQ4mvE3fSb_x-9B-Vg@mail.gmail.com>
	<CAKws9z1OLJg4EVdh1GS1vnpEPy7mDJoaX_ZETtJ4v-VivCdQww@mail.gmail.com>
	<CANUQDChDbJfDLqagSmtVW4pKtau5zTmvvO9A4hFJpdJMj_i53g@mail.gmail.com>
	<CAKws9z3x-Cg4cGwrurHj6czvgY7=2JHpoXQnseSHxK8wBs56Zw@mail.gmail.com>
	<CAGa2bXaRGcC60ifxykb=Qox5VJVEPJ4X4BFTjXirk=A_Mgi_tQ@mail.gmail.com>
Date: Fri, 31 Jul 2015 10:12:10 +0200
Message-ID: <CANUQDChYke1sagpLHY=8xdft_LAQ1751=CmDzV4izzzmw4QiRQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Scott Arciszewski <scott@paragonie.com>, Rowan Collins <rowan.collins@gmail.com>, 
	Anthony Ferrara <ircmaxell@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bacbed66875ad051c276036
Subject: Re: [PHP-DEV] Core functions throwing exceptions in PHP7
From: me@kelunik.com (Niklas Keller)

--047d7bacbed66875ad051c276036
Content-Type: text/plain; charset=UTF-8

2015-07-31 9:29 GMT+02:00 Yasuo Ohgaki <yohgaki@ohgaki.net>:

> Hi Scott,
>
> On Fri, Jul 31, 2015 at 6:33 AM, Scott Arciszewski <scott@paragonie.com>
> wrote:
>
>> On Jul 30, 2015 2:27 PM, "Niklas Keller" <me@kelunik.com> wrote:
>> > I prefer Exception, too, because it's I/O related.
>> >
>> > @Scott: You can open votes on everything, doesn't matter, just create a
>> page with a vote.
>> > I just don't know where to put it in the wiki, because it's not a RFC.
>> >
>> > Regards, Niklas
>>
>> I'm not sure how to do that.
>>
>> I have a noncritical security patch I intend to write for random_bytes()
>> that I would like to submit as a PR but first I'd like to see what the
>> resolution will be re: Exceptions.
>>
>> Also, merge conflicts aren't fun. ;)
>>
>> If there's anything I can do to get those two merged faster, please let me
>> know.
>
>
> You can have RFC vote options like
>
>  - Raise Error/Exception when CSPRNG is not available
>   (Choice: Yes/No)
>  - Use error(E_RECOVERABLE_ERROR) or exception(Whatever exception
> prefered)
>   (Choice: Error/Exception)
>
> BTW, I prefer exception, but consistency is important also.
> My vote will be Yes and Error.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
>
Hi Yasuo,

I think the question is more whether Exception or Error (class, not
E_RECOVERABLE_ERROR), to allow handling it gracefully.

Regards, Niklas

--047d7bacbed66875ad051c276036--