Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87412
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain paragonie.com from 209.85.192.49 cause and error)
MIME-Version: 1.0
In-Reply-To: <CAAyV7nFxJB79VtypdRUpc=diZL1HcQ_ACQ4mvE3fSb_x-9B-Vg@mail.gmail.com>
References: <CALYT1Yo-ae+cemXaaXs5Jv5t2DSzdxdYuxuhEGbXyoo_863+bw@mail.gmail.com>
	<836BA21C-AE99-4E7B-AB06-EBC30E41BA0E@icicle.io>
	<CAKws9z2PQWT7rSsM5R9TD-O69Ovy7-eifAuF-S0BQhBh3z4h1w@mail.gmail.com>
	<0AD335F5-35F3-4D98-8F82-800A1EDF8FD8@icicle.io>
	<05f101d0c838$fcdab5e0$f69021a0$@belski.net>
	<CAKws9z0yjxWisObfQ323rk3fA78yqJtRG=6zYDvjuPHEKH4=ag@mail.gmail.com>
	<55B63FDF.6050100@gmail.com>
	<CAKws9z1nXmci53v+3xOnROo-t45hwc9QTzJgdACBgDoi1O7DnQ@mail.gmail.com>
	<55B66494.1020106@gmail.com>
	<CAKws9z3=xJi3MwEN6Qi7Xxaphr3KLXZcAwmiN-jq924iKUpN3w@mail.gmail.com>
	<55B6707A.3040405@gmail.com>
	<CAAyV7nFxJB79VtypdRUpc=diZL1HcQ_ACQ4mvE3fSb_x-9B-Vg@mail.gmail.com>
Date: Thu, 30 Jul 2015 13:12:42 -0400
Message-ID: <CAKws9z1OLJg4EVdh1GS1vnpEPy7mDJoaX_ZETtJ4v-VivCdQww@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: Rowan Collins <rowan.collins@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Core functions throwing exceptions in PHP7
From: scott@paragonie.com (Scott Arciszewski)

On Mon, Jul 27, 2015 at 2:03 PM, Anthony Ferrara <ircmaxell@gmail.com> wrote:
> Rowan,
>
>> This is certainly some people's concern, but Anatol has raised a subtly
>> different consistency-related point, which is this:
>>
>> Since we have no policy for what kinds of Throwable should be emitted in
>> what circumstance, throwing anything in this function sets a precedent which
>> will have to be incorporated in any future plan.
>>
>> Assuming nobody is fundamentally against ever adding Throwables to core
>> functions, there are a minimum number of questions that need to be agreed
>> before adding the first one:
>> - when should we inherit from Error and when from Exception?
>
> IMHO, Errors signify programmer error, where Exceptions signify
> unknown or runtime errors. Meaning that an Error should always be a
> problem with your code, but an Exception could be a systems problem, a
> user problem or a problem in your code.
>
> While that's slightly off-topic to this discussion, it frames which
> type random_* would throw pretty clearly (Exception).
>
>> - is it ever OK to throw a plain Error or Exception (thus forcing users into
>> the otherwise bad practice of catching those base classes)?
>
> For now, I think that's a good practice. It doesn't constrain us from
> sub-typing down the road (7.1, etc), but it also lets us build the
> support in today.
>
> For example, if we throw Exception, in 7.1 we could make it
> php\RandomException in 7.1 without issue (all we need to get right is
> the hierarchy parent).
>
>> - if not throwing the base class, how specific should sub-classes be? (i.e.
>> a framework for defining the hierarchy, not necessarily the hierarchy
>> itself)
>
> I think this is something that should be RFC'd for 7.1. I don't think
> that limits us here though.
>
>> If we can get agreement on those points in time for 7.0, fine, but time is
>> very tight, and the window for such discussions has theoretically closed...
>
> I think the only real agreement we need is Error vs Exception. If we
> can agree on one of those, we can do the rest in 7.1 without worrying
> about BC...
>
> Anthony

I'm fine with either Error or Exception. I'd prefer Exception (easier
to write a sane backport for PHP 5.6) but I leave this decision in the
hands of others.

    /**
     * Slightly insane PHP 5 backport but it works
     */
    class Error extends Exception { } // Done!

Does anybody feel particularly strong about one or the other?

If so, should we set up a vote somewhere? (I don't vote karma on RFCs
etc. so I don't know if the existing infrastructure would work.)

If not, can we get PR 1397 & 1398 merged? :)

Regards,

Scott Arciszewski
Chief Development Officer
Paragon Initiative Enterprises <https://paragonie.com>