Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87385
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYRtLcE_MvH1cbELkp3RU9TCwan-N0YNQ0x_E2fztPs0Q@mail.gmail.com>
References: <CAGa2bXYgtZ8PZbmFD5hs2gj7b+MTM8-s1DvK+P5dhCU5y+W6Hw@mail.gmail.com>
	<CAEKnhAGfuy6G92=Ng4bbSOOP-mE2t5_cNXnY0QpgHnu-i4Mfjg@mail.gmail.com>
	<CAGa2bXZY3HvXd0yRaG6g-Ewuya+iLc3dsYtJFMfn9FiAbo27tA@mail.gmail.com>
	<CAAyV7nGdAKLmJG81dnG_cGDDCLduMV3gJta+YgwNp5MJ414OJQ@mail.gmail.com>
	<CAGa2bXaWu5uaa2kRvrmnO-JWsCq-uTeQUCNGvafOqHi4c4D7AA@mail.gmail.com>
	<CAGa2bXYMffoBdnh_0HmyQv23KZtsb5RWpJqjosKFa0p_66+vaQ@mail.gmail.com>
	<CAEKnhAEoVNqs6omdZgYHcX1wG3Q9VFvGciptJtr8CZJG92mG_A@mail.gmail.com>
	<CAGa2bXZLBNTXQSyA7p6dt9rgR7W_bpexz8n3HNfApGfQJPm_ng@mail.gmail.com>
	<CAEKnhAHDQM74btuqtkE8CGo1ipYGnAJ4eSX9QtS8ZSfo_xr1yw@mail.gmail.com>
	<CAGa2bXaCa=APFY=r3uprTr1axWDkCNNjJE8Us0qUucZ1B+sGYQ@mail.gmail.com>
	<CAF+90c9xwhtiZ3qbViw4hLKbWFUcT55He9KUL7+NT9MA6Cg8Xg@mail.gmail.com>
	<CAGa2bXYGnUsSmJGdFJOgwRMNDngZF868R5fEK3=TkOkW1CVdvA@mail.gmail.com>
	<CAGa2bXYRtLcE_MvH1cbELkp3RU9TCwan-N0YNQ0x_E2fztPs0Q@mail.gmail.com>
Date: Thu, 30 Jul 2015 11:06:48 +0200
Message-ID: <CAF+90c9AdCjNfddxMspunkqT3q5egn2LQs5mU0THs4VjXxC9MQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Jakub Zelenka <bukka@php.net>, Anthony Ferrara <ircmaxell@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d043c7ec4fb8180051c140500
Subject: Re: [PHP-DEV] json_decode/encode should return full precision values
 by default
From: nikita.ppv@gmail.com (Nikita Popov)

--f46d043c7ec4fb8180051c140500
Content-Type: text/plain; charset=UTF-8

On Thu, Jul 30, 2015 at 1:25 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> On Thu, Jul 30, 2015 at 7:44 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>> On Thu, Jul 30, 2015 at 1:13 AM, Nikita Popov <nikita.ppv@gmail.com>
>> wrote:
>>
>>> Instead of continuing to use serialize_precision, which will produce
>>> unnecessarily long outputs for many values, why don't we just switch to
>>> using the 0 mode of zend_dtoa, i.e. to return the shortest output that is
>>> still accurate if interpreted in round-to-nearest. I think this is what
>>> everybody else is using when they convert floating point numbers to
>>> strings. I guess we may not be able to change normal floating point
>>> printing to use this, but this seems like the best mode for anything using
>>> serialize_precision now and everything that should be using it (like JSON,
>>> and queries, etc).
>>
>>
>> I prefer your proposal!
>> Your proposal is a lot better than now.
>> Anyone has opinion for this?
>>
>> I'm writing the RFC and I would like to make this the first option. i.e.
>> serialize_precision=0 uses "zend_dtoa 0 mode" for all data exchange
>> functions (json/serialize/var_exrport. Anyone care about WDDX/XML_RPC?)
>>
>
> I wrote draft RFC.
>
> https://wiki.php.net/rfc/precise_float_value
>
> Please comment. I would like to start RFC discussion shortly.
> Thank you.
>

Nice idea about using a special serialize_precision value for this. This
allows to keep BC for those that have tests for particular serialize output
or similar things.

I would suggest to default serialize_precision to -1 in PHP 7 -- if people
want the previous behavior they can still have it, but I think -1 is the
more reasonable default as it matches what one would naturally expect.

I don't see the need for having a separate setting for JSON. Having a dozen
different float precision settings will not help anyone.

Nikita

--f46d043c7ec4fb8180051c140500--