Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87380
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYRtLcE_MvH1cbELkp3RU9TCwan-N0YNQ0x_E2fztPs0Q@mail.gmail.com>
References: <CAGa2bXYgtZ8PZbmFD5hs2gj7b+MTM8-s1DvK+P5dhCU5y+W6Hw@mail.gmail.com>
	<CAEKnhAGfuy6G92=Ng4bbSOOP-mE2t5_cNXnY0QpgHnu-i4Mfjg@mail.gmail.com>
	<CAGa2bXZY3HvXd0yRaG6g-Ewuya+iLc3dsYtJFMfn9FiAbo27tA@mail.gmail.com>
	<CAAyV7nGdAKLmJG81dnG_cGDDCLduMV3gJta+YgwNp5MJ414OJQ@mail.gmail.com>
	<CAGa2bXaWu5uaa2kRvrmnO-JWsCq-uTeQUCNGvafOqHi4c4D7AA@mail.gmail.com>
	<CAGa2bXYMffoBdnh_0HmyQv23KZtsb5RWpJqjosKFa0p_66+vaQ@mail.gmail.com>
	<CAEKnhAEoVNqs6omdZgYHcX1wG3Q9VFvGciptJtr8CZJG92mG_A@mail.gmail.com>
	<CAGa2bXZLBNTXQSyA7p6dt9rgR7W_bpexz8n3HNfApGfQJPm_ng@mail.gmail.com>
	<CAEKnhAHDQM74btuqtkE8CGo1ipYGnAJ4eSX9QtS8ZSfo_xr1yw@mail.gmail.com>
	<CAGa2bXaCa=APFY=r3uprTr1axWDkCNNjJE8Us0qUucZ1B+sGYQ@mail.gmail.com>
	<CAF+90c9xwhtiZ3qbViw4hLKbWFUcT55He9KUL7+NT9MA6Cg8Xg@mail.gmail.com>
	<CAGa2bXYGnUsSmJGdFJOgwRMNDngZF868R5fEK3=TkOkW1CVdvA@mail.gmail.com>
	<CAGa2bXYRtLcE_MvH1cbELkp3RU9TCwan-N0YNQ0x_E2fztPs0Q@mail.gmail.com>
Date: Wed, 29 Jul 2015 17:35:10 -0600
Message-ID: <CAObuZdtTsncej_Hak+XXyU4Cw-sEbO0CZpng=23MS-p65zFuFQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Jakub Zelenka <bukka@php.net>, 
	Anthony Ferrara <ircmaxell@gmail.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec54fb2c4ac3163051c0c0911
Subject: Re: [PHP-DEV] json_decode/encode should return full precision values
 by default
From: derokorian@gmail.com (Ryan Pallas)

--bcaec54fb2c4ac3163051c0c0911
Content-Type: text/plain; charset=UTF-8

On Wed, Jul 29, 2015 at 5:25 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> On Thu, Jul 30, 2015 at 7:44 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> > On Thu, Jul 30, 2015 at 1:13 AM, Nikita Popov <nikita.ppv@gmail.com>
> > wrote:
> >
> >> Instead of continuing to use serialize_precision, which will produce
> >> unnecessarily long outputs for many values, why don't we just switch to
> >> using the 0 mode of zend_dtoa, i.e. to return the shortest output that
> is
> >> still accurate if interpreted in round-to-nearest. I think this is what
> >> everybody else is using when they convert floating point numbers to
> >> strings. I guess we may not be able to change normal floating point
> >> printing to use this, but this seems like the best mode for anything
> using
> >> serialize_precision now and everything that should be using it (like
> JSON,
> >> and queries, etc).
> >
> >
> > I prefer your proposal!
> > Your proposal is a lot better than now.
> > Anyone has opinion for this?
> >
> > I'm writing the RFC and I would like to make this the first option. i.e.
> > serialize_precision=0 uses "zend_dtoa 0 mode" for all data exchange
> > functions (json/serialize/var_exrport. Anyone care about WDDX/XML_RPC?)
> >
>
> I wrote draft RFC.
>
> https://wiki.php.net/rfc/precise_float_value
>
> Please comment. I would like to start RFC discussion shortly.
> Thank you.
>

My thought would be why not -1 to make it obvious it has special meaning?
When I see precision=0 I tend to think that means my numbers will be
returned as ints no matter what (there is zero fractional precision)
whereas this takes a valid value for precision and gives it special
meaning. I fully support your end game, but giving a valid value a special
meaning I do not like.


>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

--bcaec54fb2c4ac3163051c0c0911--