Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:87373 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33753 invoked from network); 29 Jul 2015 20:51:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Jul 2015 20:51:27 -0000 Authentication-Results: pb1.pair.com header.from=scott@paragonie.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=scott@paragonie.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain paragonie.com from 209.85.220.171 cause and error) X-PHP-List-Original-Sender: scott@paragonie.com X-Host-Fingerprint: 209.85.220.171 mail-qk0-f171.google.com Received: from [209.85.220.171] ([209.85.220.171:34086] helo=mail-qk0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BD/B0-25901-DCC39B55 for ; Wed, 29 Jul 2015 16:51:26 -0400 Received: by qkfc129 with SMTP id c129so11321968qkf.1 for ; Wed, 29 Jul 2015 13:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=waWlpjdkS06Di4HYMGRji2jKaO3p6dQBaEgLH6auqCM=; b=NFt3yvmk4GBdxtIJOTZi0uRGMjLWeL4qoY3S7J4ZPIbiqFHrz1w+vrN9id163BA/h4 QzrRAjqTQ8menMU6v30Av1sMYVCYKzUJ7/wYA+B7r7VN9Fko5xzYBDeWbeItjPIFax2Q oPB3xzbD/NEGca242kW0zcHlAfSCdmwtFVlojRrpieIRBIpNWRLyzZriF752GgT1LkGu wueC2+7fPe8JFbbrsQUARigsIJ6H1TcbJS54L95g1ncGmDIyJjklevH529Xd/VBN9PJw rtX+v8CR/z2OVtr65fDOULBQ3V2Nzvty2165Y+dMonyQMpuxz1ghRuxCA72vbkGeuXA3 Thgw== X-Gm-Message-State: ALoCoQkyAPvWOGlCVXkfeVx80vqE33e2MGhdvbIRtILpv876DOE8g6waYPiUhaz94k0CxKqaTInc MIME-Version: 1.0 X-Received: by 10.55.27.97 with SMTP id b94mr64649547qkb.3.1438203083281; Wed, 29 Jul 2015 13:51:23 -0700 (PDT) Received: by 10.96.83.102 with HTTP; Wed, 29 Jul 2015 13:51:23 -0700 (PDT) In-Reply-To: References: Date: Wed, 29 Jul 2015 16:51:23 -0400 Message-ID: To: Anthony Ferrara Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Disabling External Entities in libxml By Default From: scott@paragonie.com (Scott Arciszewski) On Wed, Jul 29, 2015 at 4:37 PM, Anthony Ferrara wrote: > All, > > I wanted to float an idea by you for PHP 7 (or 7.1 depending on the > RM's feedback). > > Currently, PHP by default is vulnerable to XXE attacks: > https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing > > To bypass this, you need to turn off external entity loading: > > libxml_disable_entity_loader(true); > > What I'm proposing is to disable entity loading by default. That way > it requires developers to opt-in to actually load external entities. > > Thoughts? > > Anthony > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > Enormous +1 to this from me. This should definitely be off by default. Scott Arciszewski Chief Development Officer Paragon Initiative Enterprises