Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87357
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain malkusch.de designates 31.47.225.241 as permitted sender)
Message-ID: <55B7F53A.30308@malkusch.de>
Date: Tue, 28 Jul 2015 23:33:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: internals@lists.php.net
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="2PN1HCmCEXnruLkoxKdLWPdwcOEtbIhKs"
Subject: Throwable::addSuppressed()
From: markus@malkusch.de (Markus Malkusch)

--2PN1HCmCEXnruLkoxKdLWPdwcOEtbIhKs
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi PHP

So I read that there's this Throwable interface coming. Great! How about
extending it with one further method:

void Throwable::addSuppressed(Throwable exception)

Semantic is the same as Java's Throwable.addSuppressed()=C2=B9.

Why? Well consider a code fragment which wants to close a resource
during an exception:

} catch (Exception $e1) {
    try {
        $resource->close();
        throw $e1;

    } catch (ResourceException $e2) {
        // The information about $e2 is lost.
        throw $e1;
    }
}

Currently PHP has no method to propagate both $e1 and $e2. With
Throwable::addSuppressed() $e2 could be added as a suppressed exception
to $e1:

} catch (Exception $e1) {
    try {
        $resource->close();

    } catch (ResourceException $e2) {
        e1->addSuppressed($e2);

    }
    throw $e1;
}

To make this information useful (for e.g. a logger) there's one further
method needed:

Throwable[] Throwable::getSuppressed()

So PHP, what do you think, might a RFC find acceptance?

Best wishes
Markus Malkusch

[1]:
http://docs.oracle.com/javase/8/docs/api/java/lang/Throwable.html#addSupp=
ressed-java.lang.Throwable-


--2PN1HCmCEXnruLkoxKdLWPdwcOEtbIhKs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlW39UAACgkQ/RRK96H7DMT+AACcD7nUPxti6JMy/tRv85D+RDEI
iAYAn1ye2OF5JaEvh2H8rvRdjdtM+t5m
=j52S
-----END PGP SIGNATURE-----

--2PN1HCmCEXnruLkoxKdLWPdwcOEtbIhKs--