Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87283
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.173 as permitted sender)
To: Xinchen Hui <laruence@php.net>, PHP Internals <internals@lists.php.net>
References: <CABBJUpcWPCENkJn3gBE0fck1=qvjDJKxU9WTf2JkRmsbLEtw0A@mail.gmail.com>
Message-ID: <55B2DA8A.50202@gmail.com>
Date: Fri, 24 Jul 2015 17:38:34 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CABBJUpcWPCENkJn3gBE0fck1=qvjDJKxU9WTf2JkRmsbLEtw0A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Make debug_zval_dump prints int as long
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

>     I made a small PR about changes output of some types name in
> debug_zval_dump, to make it behavior consistently with var_dump.
> https://github.com/php/php-src/pull/1434
> 
>     2 things are changed:
> 
>     1. print int instead of long
>     2. print float instead of double.

I think that's fine, it's a debug function, even says it in the name.
Also pretty deep into engine internals. So I don't think is it a
problem. Just add a note to UPGRADING.

-- 
Stas Malyshev
smalyshev@gmail.com