Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87279
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.172 as permitted sender)
To: Rowan Collins <rowan.collins@gmail.com>, internals@lists.php.net
References: <CALYT1Yo-ae+cemXaaXs5Jv5t2DSzdxdYuxuhEGbXyoo_863+bw@mail.gmail.com>
 <55A63C90.8000705@gmail.com>
Message-ID: <55B2D10D.4030807@gmail.com>
Date: Fri, 24 Jul 2015 16:58:05 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <55A63C90.8000705@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Core functions throwing exceptions in PHP7
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Given that the *engine itself* now throws exceptions, and we have
> bundled extensions which throw exceptions, the blanket ban on exceptions
> "in core functions" seems increasingly out-dated. This particular

I agree. I think once we agreed we want to convert from fatals to
exceptions, we need to recognize exceptions as a first-class citizen.
Which means using it in internal functions is OK.

Now, there is a big gap between E_WARNING on one side and
E_ERROR/exception on the other side. Whether particular function crosses
this gap or not is a case-by-case discussion, but "we can not use
exceptions in core" should no longer be a part of it.

> too quickly. I'm also a big fan of proper exception hierarchies - I've
> seen so many times that you should never *catch* the base Exception
> class, so *throwing* a base Exception seems very wrong to me.

Agreed. Maybe we should have something like RuntimeException or Java?
That is pretty generic too, but at least not Exception.

-- 
Stas Malyshev
smalyshev@gmail.com