Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:87272 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 91471 invoked from network); 24 Jul 2015 12:58:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jul 2015 12:58:34 -0000 Authentication-Results: pb1.pair.com header.from=cmbecker69@gmx.de; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=cmbecker69@gmx.de; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.20 as permitted sender) X-PHP-List-Original-Sender: cmbecker69@gmx.de X-Host-Fingerprint: 212.227.17.20 mout.gmx.net Received: from [212.227.17.20] ([212.227.17.20:63109] helo=mout.gmx.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 23/F4-57278-97632B55 for ; Fri, 24 Jul 2015 08:58:34 -0400 Received: from [192.168.0.100] ([95.89.139.132]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Lt1yI-1Yu3DL04OA-012Xrg; Fri, 24 Jul 2015 14:58:21 +0200 Message-ID: <55B23674.9010208@gmx.de> Date: Fri, 24 Jul 2015 14:58:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Zuelke , Adam Harvey CC: PHP internals References: <55B0CADD.8000807@gmx.de> <55B136BE.8010006@gmx.de> <787E3411-1213-44C0-809D-D1D8CA89277A@heroku.com> In-Reply-To: <787E3411-1213-44C0-809D-D1D8CA89277A@heroku.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:RzLKQQMpAwjc3xCrEsVjXTzsR29SXIq6tdNZhp07/+bN743Pd8h YoD95ifoCmWbI1cSOnRtt5ljDyIqEnR4AVX7yztil6wLBIH2/C4tbTqlb6xEOr8C6+lhMqW tPTpFyOgqgSl3YtoR/L8kIcnw5L4Am+B50ib6Q2JYpCZvKDIRKCWEHfXL3Ld7bKEFwNorvn DUFo2OdSIcvfhpc8IerKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6yS1PyO7zU8=:elQMNvGJ7Ecsj9A7MACgEC tt6UWImCDkOXFRdEpwBlYxCmc7DfKYmfL7NcVJkD/zDJSPNNnR+AJ9+nsuAigSE4CK2lqlFhS HWp3l/mIQjp1zNDvkpQhhJAkvsjmQNWC5tigG3jsTxz7WEFiGeH9C3lxig7d2ASAvNp++srmW /N1r3cB8MR1o335A58tpPPT51dovVgDCCHC77ufOSCR/HQWWpQwWahGZ8OmWJvkzZeIpDe1Wc Q1/FnzBt5c9U7527nc/4zmZYZ//qKtFJ3JtxZHXPb8MMMIkVpQkKZjSwkURKzvB5WQNQj2cpC zE3+t3OojWrbcWFIDTC9qjJ47DPdmZr6u01CgFdgyVdCuefaDPOBsgTIEBiajp0KtohTfxaKP +myunC37kMcUJR6cKOOEIAb+YZQbpdtdJ9FBMtvUrn4oQhPqCxrmA4Qss7tEZ4HLOWnZKt9YX fQBnOPZXjEGJ4VPW4wvo51bDO4YK2sO5IojYmDrgJvrMIsa6uaefpmXZBsXnewel/NADyuNCm hK+FYpmZ2hXx09hEsocZ7HURxf5WYL6IZ8C7hVSFVp7dDrmRPQOzRIRT+9twSfHPmyApSTJ8h L1dRK0O36lA9qlHOhG3ps+HR+WL7ae4jrc1mBY/xknygehYzYSXl1BYqT5i1CNmwKRvTNAijw lHSLDgxcc7u14LZH9lxynTyq4aF2TmeIcXAUTpyoEvmGm/zkwplmyuOsYPo7LeBL07vs= Subject: Re: [PHP-DEV] PCRE JIT stack size limit From: cmbecker69@gmx.de (Christoph Becker) On 24.07.2015 at 14:32, David Zuelke wrote: > On 24.07.2015, at 09:33, Adam Harvey wrote: >> >> On 23 July 2015 at 11:47, Christoph Becker wrote: >> >>> Therefore I tend to prefer a new ini setting (say, pcre.jitstack_limit). >>> That would mean, however, to add yet another ini setting, of which >>> there are already so many. >> >> I'm not a big fan of that, although it's at least in the spirit of >> what configuration settings are meant to be used for. >> >> What if we added the PCRE_ERROR_JIT_STACKLIMIT error constant to those >> exposed to userland so that it's more easily noticed via >> preg_last_error(), and adding a modifier that can be used to disable >> the JIT on a per-pattern basis (by setting PCRE_NO_START_OPTIMIZE, >> which admittedly disables other stuff too, but at least the regex will >> run)? At least then users could check the error when the regex fails >> and re-run the regex without the JIT if they chose to. > > But this might mean that patterns which previously worked, because no JIT was used, suddenly fail in existing code with a new error constant. Which I guess is a BC break. Maybe it's best to change the default of pcre.jit to "0"? -- Christoph M. Becker