Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87269
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpcWPCENkJn3gBE0fck1=qvjDJKxU9WTf2JkRmsbLEtw0A@mail.gmail.com>
References: <CABBJUpcWPCENkJn3gBE0fck1=qvjDJKxU9WTf2JkRmsbLEtw0A@mail.gmail.com>
Date: Fri, 24 Jul 2015 19:17:18 +0700
Message-ID: <CAEZPtU50br8J8=H4rGRk8guiLYLNr24tDH5LHXXrwgiB+=44mw@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113db7d4445f82051b9dfca4
Subject: Re: [PHP-DEV] Make debug_zval_dump prints int as long
From: pierre.php@gmail.com (Pierre Joye)

--001a113db7d4445f82051b9dfca4
Content-Type: text/plain; charset=UTF-8

On Jul 24, 2015 11:21 AM, "Xinchen Hui" <laruence@php.net> wrote:
>
> Hey:
>
>     I made a small PR about changes output of some types name in
> debug_zval_dump, to make it behavior consistently with var_dump.
> https://github.com/php/php-src/pull/1434
>
>     2 things are changed:
>
>     1. print int instead of long
>     2. print float instead of double.
>
>     RM and me are worrying about this will break some APPs unit tests
> .. anyway, welting doesn't find any in github..
>
>     so,  is there any objections to merge this into PHP7.0?

Some consistencies changes in debug functions are fine imho.

Cheers,
Pierre

--001a113db7d4445f82051b9dfca4--