Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:87265 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69771 invoked from network); 24 Jul 2015 08:39:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jul 2015 08:39:54 -0000 Authentication-Results: pb1.pair.com smtp.mail=remi@fedoraproject.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=remi@fedoraproject.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.195 cause and error) X-PHP-List-Original-Sender: remi@fedoraproject.org X-Host-Fingerprint: 217.70.183.195 relay3-d.mail.gandi.net Received: from [217.70.183.195] ([217.70.183.195:55405] helo=relay3-d.mail.gandi.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 43/22-57278-8D9F1B55 for ; Fri, 24 Jul 2015 04:39:53 -0400 Received: from mfilter16-d.gandi.net (mfilter16-d.gandi.net [217.70.178.144]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 3B618A80FA for ; Fri, 24 Jul 2015 10:39:49 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter16-d.gandi.net Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter16-d.gandi.net (mfilter16-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id O_dTXW1_r9Xc for ; Fri, 24 Jul 2015 10:39:47 +0200 (CEST) X-Originating-IP: 82.241.130.121 Received: from schrodingerscat.famillecollet.com (pom51-2-82-241-130-121.fbx.proxad.net [82.241.130.121]) (Authenticated sender: contact@ll-experts.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C8002A8100 for ; Fri, 24 Jul 2015 10:39:47 +0200 (CEST) To: PHP Internals References: <55AF84C1.8070403@fedoraproject.org> Message-ID: <55B1F9D3.7010000@fedoraproject.org> Date: Fri, 24 Jul 2015 10:39:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] RFE to allow dirname($foo, 2) From: remi@fedoraproject.org (Remi Collet) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 24/07/2015 02:11, Hannes Magnusson a =C3=A9crit : > On Wed, Jul 22, 2015 at 4:55 AM, Remi Collet > wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >>=20 >> See https://bugs.php.net/bug.php?id=3D70112 >>=20 >>=20 >> As this a very small self-contained change, I don't think it >> needs a RFE. >>=20 >> Feedback welcome >=20 >=20 >=20 >=20 > Shouldn't you check if you are at the root (or cwd)? currently > dirname("/foo/bar", PHP_INT_MAX); "hangs" Good catch. Should be ok now. Remi. >=20 >=20 > -Hannes >=20 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlWx+dMACgkQYUppBSnxahjuPACgxZ+yLXbLzQXZKmJhWAbH0OD9 jqAAnjImkjL6j+p4dsRC0IC8N6fRKFXc =3D4YM4 -----END PGP SIGNATURE-----