Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87244
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Remi Collet'" <remi@fedoraproject.org>,
	"'PHP Internals'" <internals@lists.php.net>
References: <55AF84C1.8070403@fedoraproject.org> <CAESVnVrx75JXUEVchWFaXnFgLO5KzGNDdK1EBYjqXVzyPMLgQQ@mail.gmail.com> <CADyq6sJ274kzA0GqBXGOMA=t7woPfXC9a-KaRyr-nfASAxMi_A@mail.gmail.com> <55B07B98.1050909@fedoraproject.org>
In-Reply-To: <55B07B98.1050909@fedoraproject.org>
Date: Thu, 23 Jul 2015 12:17:47 +0200
Message-ID: <020501d0c530$d4263440$7c729cc0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQK6O6+cvVhGbhyp5NGRGiY/9DHs2AHICuffAqXFzncCPhDDbZvghrJg
Content-Language: en-us
Subject: RE: [PHP-DEV] RFE to allow dirname($foo, 2)
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: Remi Collet [mailto:remi@fedoraproject.org]
> Sent: Thursday, July 23, 2015 7:29 AM
> To: PHP Internals <internals@lists.php.net>
> Subject: Re: [PHP-DEV] RFE to allow dirname($foo, 2)
>=20
> Le 22/07/2015 20:57, Marco Pivetta a =C3=A9crit :
> > On 22 July 2015 at 19:49, Sara Golemon <pollita@php.net
> > <mailto:pollita@php.net>> wrote:
> >
> > On Wed, Jul 22, 2015 at 4:55 AM, Remi Collet <remi@fedoraproject.org
> > <mailto:remi@fedoraproject.org>> wrote:
> >> See https://bugs.php.net/bug.php?id=3D70112
> >>
> > I'm not inherently against it, but this really really sounds like a
> > job for a userspace function.
> >
> > function dirname_n($path, $n) { while (($path !=3D=3D '.') && $n--) =
$path
> > =3D dirname($path); return $path; }<http://www.php.net/unsub.php>
> >
> >
> > Indeed. What need is there to add a functionality to a relatively
> > simple function like this one? What's the actual advantage that =
cannot
> > be achieved in userland code?
> >
>=20
> Legibility and the frequency of the usage of dirname(dirname(...
> in various pieces of code.
>=20
> See
> =
https://github.com/search?q=3Ddirname+__DIR__+language%3Aphp&ref=3Dsearch=
r
> esults&type=3DCode&utf8=3D%E2%9C%93
>=20
> As github search doesn't allow to search for (, I use __dir__ which =
probably hides
> more usage.
>=20
> As "n" is usually 2 or 3, nobody will write a userland function.
>=20
IMHO the idea is not doing any harm while solving a real use case. I =
wouldn't resist to take it in, especially if there are more useful cases =
and we can test the patch early.

One more note is that it's somehow logic coupled with mkdir having the =
recursive option. Also it's useful for including the autoloader as no =
custom library functions are available yet. A downside could be - it =
will encourage people writing a non PHP5 compatible code (or maybe it's =
not an issue).

Regards

Anatol