Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87237
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.172 as permitted sender)
MIME-Version: 1.0
Sender: dmgx.michael@gmail.com
In-Reply-To: <55AE8515.7050905@gmail.com>
References: <CAGovj_O+f9md5F8DntpynaHqMHNFMqvZApOo=GMZAA7Od9mxsg@mail.gmail.com>
	<55AE8515.7050905@gmail.com>
Date: Wed, 22 Jul 2015 15:30:25 -0400
Message-ID: <CAGovj_PwTQMqnK7yFq_8Wj8RVH=W9OwUtEUdQ2Ei80fxjz6U+g@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113f8eee7aecbd051b7bcd07
Subject: Re: [PHP-DEV] List of possible E_RECOVERABLE_ERRORs
From: tendoaki@gmail.com (Michael Morris)

--001a113f8eee7aecbd051b7bcd07
Content-Type: text/plain; charset=UTF-8

I was provided with such a grep of PHP 5.6 and have begun the mapping. I've
set up this composer package for it.

https://packagist.org/packages/aki-tendo/php7exception

and the git if someone has some time to chip in.

https://github.com/TendoAki/php-7-exceptions-in-php-5

Currently I have AssertionError mapped since that is dirt simple to do.
From here out it's a bit more unclear. Now, the main goal here is to make
the @expectedException annotation work the same way in PHP 5 and 7 for
these errors. That said, how many of these will actually get units aimed at
them? Probably not many.

My first thought is to strpos the message string for the word "Argument"
and if that returns 0 then I know it's a TypeError and can throw that.
Apparently eval() can raise E_RECOVERABLE, so that maps to ParseError.  All
others to Error?

I would appreciate some guidance on this - smoothing the transition from 5
to 7 helps all of us.

On Tue, Jul 21, 2015 at 1:44 PM, Rowan Collins <rowan.collins@gmail.com>
wrote:

> Michael Morris wrote on 21/07/2015 18:11:
>
>> Hi.  I hate to ask an outright question on the list rather but I've been
>> searching the last 5 hours for an answer to this and haven't found
>> anything
>> and it's a rather tight corner case. I'm working on a small package for
>> PHP
>> 5.x that uses set_error_handler() to convert E_RECOVERABLE_ERRORs to the
>> appropriate PHP 7 exceptions.  I know I can't emulate things exactly - my
>> goal is to get things so that PHPUnit tests can use the same
>> @expectedException annotation for these scenarios, simplifying unit test
>> writing.
>>
>> As far as my research has found E_RECOVERABLE_ERROR has only ever been
>> used
>> for type hint failures.  Are there any other errors that have this type,
>> and if so to what PHP 7 exception should they be converted?
>>
>>
> You should be able to figure out with a grep of the source code for use of
> that constant (it has the same name in C as in PHP). A quick glance on
> lxr.php.net shows a few other uses:
> http://lxr.php.net/search?q=&defs=&refs=E_RECOVERABLE_ERROR&path=&hist=&project=PHP_5_6
>
> Regards,
> --
> Rowan Collins
> [IMSoP]
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--001a113f8eee7aecbd051b7bcd07--