Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87222
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1507211250220.13034@whisky.home.derickrethans.nl>
References: <CADyq6sLOTQW2TQ0t3XJzSRtc7m33tL9vFNWFjfBwwEuHpU-ZRA@mail.gmail.com>
 <op.x14bn4vo7q1gix@nikita-hp-elitebook-750-g1> <CADyq6sKdwUc3y2g8e9QanXWSKLzE0i4YGmCmNQTQ5khD4_Z46A@mail.gmail.com>
 <CADyq6sLAYMueU2UR2rLZAKChUq0BNz4pu4Sg_8eYctV8an6PBA@mail.gmail.com> <alpine.DEB.2.20.1507211250220.13034@whisky.home.derickrethans.nl>
Date: Tue, 21 Jul 2015 13:29:12 +0100
Message-ID: <CADyq6sK8FYay4yRoO_43t8N47WYCGuxzJyVZ50N4Cxttr_dqhA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Niktia Nefedov <inefedor@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8f5035646271d6051b61ce91
Subject: Re: [PHP-DEV] DateTimeInterface is not a usable interface?
From: ocramius@gmail.com (Marco Pivetta)

--e89a8f5035646271d6051b61ce91
Content-Type: text/plain; charset=UTF-8

On 21 July 2015 at 12:56, Derick Rethans <derick@php.net> wrote:

> On Tue, 21 Jul 2015, Marco Pivetta wrote:
>
> > I should also add that this breaking change was introduced in a patch
> > release (5.5.8).
>
> That wasn't good, but I don't see how it was a *breaking* change. It
> never worked before this change either. You now just told you're doing
> something inappropriate.
>

It's an interface, it doesn't "work", it simply gets implemented (then the
implementing code "works").


> > What has happened has happened, and I don't want to blame anyone, but
> > this is actually really broken :-\
>
> It's not a check that can be easily removed though. As Nikita says, this
> all operate on internal structures. DateTimeInterface is meant so that
> both DateTime and DateTimeImmutable can be type hinted for, and not
> really for user land. Retrofitting PHP's DateTime stuff with user
> extended classes and implementations is not going to be a trivial thing.
>

Then make DateTime and DateTimeImmutable only interact with DateTime and
DateTimeImmutable (or child classes), but don't rely on the interface if
you're not actually respecting it internally in first place, no?

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--e89a8f5035646271d6051b61ce91--