Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:87204
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.181 as permitted sender)
To: internals@lists.php.net
References: <CALYT1Yo-ae+cemXaaXs5Jv5t2DSzdxdYuxuhEGbXyoo_863+bw@mail.gmail.com>
 <55A7D993.5000301@moonspot.net>
Message-ID: <55A7DC8F.30606@gmail.com>
Date: Thu, 16 Jul 2015 17:32:15 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <55A7D993.5000301@moonspot.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Core functions throwing exceptions in PHP7
From: rowan.collins@gmail.com (Rowan Collins)

Brian Moon wrote on 16/07/2015 17:19:
> On the surface, this sounds like a good thing. Although, I question 
> that if a user is not checking $result === false, then will they end 
> up just wrapping this in an empty try/catch so their code does not 
> fail? There is a mechanism to detect the error now.
>
> I question why the cryptographic functions would not force an integer 
> to be passed. Those should not accept a boolean and evaluate it as 
> false. I am not sure what functions you are talking about though. 
> Maybe 3rd party user land code? Accepting a boolean in those cases is 
> a bug in that code IMO.
>

Scott provided an example elsewhere in the thread:

>      $max = strlen($alphabet) - 1;
>      for ($i = 0; $i < 32; ++$i) {
>          $password .= $alphabet[random_int(0, $max)];
>      }

That demonstrates both a situation where booleans can't be excluded, and 
where you'd have to try pretty hard to silently catch the exception in a 
way that left your code broken. I suppose you could forget to check if 
the generated password is empty, but that doesn't seem all that likely. 
If you've gone to the trouble of putting a try block in, you're at least 
aware that the function CAN fail.

Regards,
-- 
Rowan Collins
[IMSoP]